Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673608 > unrolled thread
| Started by | Mario Limonciello <mario.limonciello@dell.com> |
|---|---|
| First post | 2017-06-23 16:40 +0200 |
| Last post | 2017-06-23 23:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 Mario Limonciello <mario.limonciello@dell.com> - 2017-06-23 16:40 +0200
Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 Darren Hart <dvhart@infradead.org> - 2017-06-23 23:20 +0200
| From | Mario Limonciello <mario.limonciello@dell.com> |
|---|---|
| Date | 2017-06-23 16:40 +0200 |
| Subject | [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 |
| Message-ID | <tVxUC-3mk-17@gated-at.bofh.it> |
Pali recently noticed that WMI instances are zero indexed. The only reason that these calls all worked properly is because the ASL didn't verify the instance number. Signed-off-by: Louis Davis <louis.davis@dell.com> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> --- drivers/platform/x86/dell-wmi-led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-wmi-led.c b/drivers/platform/x86/dell-wmi-led.c index a0c7e99..5bedaf7 100644 --- a/drivers/platform/x86/dell-wmi-led.c +++ b/drivers/platform/x86/dell-wmi-led.c @@ -68,7 +68,7 @@ static int dell_led_perform_fn(u8 length, u8 result_code, u8 device_id, input.length = sizeof(struct bios_args); input.pointer = &args; - status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output); + status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 0, 1, &input, &output); if (ACPI_FAILURE(status)) return status; -- 2.7.4
[toc] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2017-06-23 23:20 +0200 |
| Subject | Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 |
| Message-ID | <tVE9I-7ka-13@gated-at.bofh.it> |
| In reply to | #1673608 |
On Fri, Jun 23, 2017 at 09:35:21AM -0500, Mario Limonciello wrote: > Pali recently noticed that WMI instances are zero indexed. > > The only reason that these calls all worked properly is because the ASL > didn't verify the instance number. > > Signed-off-by: Louis Davis <louis.davis@dell.com> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> Thanks, queued to testing. -- Darren Hart VMware Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web