[PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0

From	Mario Limonciello <mario.limonciello@dell.com>
Newsgroups	linux.kernel
Subject	[PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0
Date	2017-06-23 16:40 +0200
Message-ID	<tVxUC-3mk-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Pali recently noticed that WMI instances are zero indexed.

The only reason that these calls all worked properly is because the ASL
didn't verify the instance number.

Signed-off-by: Louis Davis <louis.davis@dell.com>
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
 drivers/platform/x86/dell-wmi-led.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-wmi-led.c b/drivers/platform/x86/dell-wmi-led.c
index a0c7e99..5bedaf7 100644
--- a/drivers/platform/x86/dell-wmi-led.c
+++ b/drivers/platform/x86/dell-wmi-led.c
@@ -68,7 +68,7 @@ static int dell_led_perform_fn(u8 length, u8 result_code, u8 device_id,
 	input.length = sizeof(struct bios_args);
 	input.pointer = &args;
 
-	status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
+	status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 0, 1, &input, &output);
 	if (ACPI_FAILURE(status))
 		return status;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 Mario Limonciello <mario.limonciello@dell.com> - 2017-06-23 16:40 +0200
  Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method  calls to 0 Darren Hart <dvhart@infradead.org> - 2017-06-23 23:20 +0200

csiph-web