Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673482 > unrolled thread

[linux-next:master 6255/9581] drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was not declared. Should it be static?

Back to article view | Back to linux.kernel

Contents

  [linux-next:master 6255/9581]  drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was  not declared. Should it be static? kbuild test robot <fengguang.wu@intel.com> - 2017-06-23 13:30 +0200
    [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static kbuild test robot <fengguang.wu@intel.com> - 2017-06-23 13:30 +0200
      Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-06-23 13:40 +0200

#1673482 — [linux-next:master 6255/9581] drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   a73468728fd8f34ccbd7c60f0808024ae491f4d6
commit: 1b9f35adb0ffa143c7972a8459d6979c77d6c3c0 [6255/9581] usb: gadget: udc: Add Synopsys UDC Platform driver
reproduce:
        # apt-get install sparse
        git checkout 1b9f35adb0ffa143c7972a8459d6979c77d6c3c0
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was not declared. Should it be static?
>> drivers/usb/gadget/udc/snps_udc_plat.c:41:6: sparse: symbol 'stop_udc' was not declared. Should it be static?
>> drivers/usb/gadget/udc/snps_udc_plat.c:79:6: sparse: symbol 'udc_drd_work' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1673483 — [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 snps_udc_plat.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
index 2e11f19..f7b4d0f 100644
--- a/drivers/usb/gadget/udc/snps_udc_plat.c
+++ b/drivers/usb/gadget/udc/snps_udc_plat.c
@@ -28,7 +28,7 @@
 /* description */
 #define UDC_MOD_DESCRIPTION     "Synopsys UDC platform driver"
 
-void start_udc(struct udc *udc)
+static void start_udc(struct udc *udc)
 {
 	if (udc->driver) {
 		dev_info(udc->dev, "Connecting...\n");
@@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
 	}
 }
 
-void stop_udc(struct udc *udc)
+static void stop_udc(struct udc *udc)
 {
 	int tmp;
 	u32 reg;
@@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
 	dev_info(udc->dev, "Device disconnected\n");
 }
 
-void udc_drd_work(struct work_struct *work)
+static void udc_drd_work(struct work_struct *work)
 {
 	struct udc *udc;
 

[toc] | [prev] | [next] | [standalone]

#1673486 — Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

Looks good to me.

Thanks,
Ravi

On Fri, Jun 23, 2017 at 4:50 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  snps_udc_plat.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19..f7b4d0f 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -28,7 +28,7 @@
>  /* description */
>  #define UDC_MOD_DESCRIPTION     "Synopsys UDC platform driver"
>
> -void start_udc(struct udc *udc)
> +static void start_udc(struct udc *udc)
>  {
>         if (udc->driver) {
>                 dev_info(udc->dev, "Connecting...\n");
> @@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
>         }
>  }
>
> -void stop_udc(struct udc *udc)
> +static void stop_udc(struct udc *udc)
>  {
>         int tmp;
>         u32 reg;
> @@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
>         dev_info(udc->dev, "Device disconnected\n");
>  }
>
> -void udc_drd_work(struct work_struct *work)
> +static void udc_drd_work(struct work_struct *work)
>  {
>         struct udc *udc;
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web