Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static

From	Raviteja Garimella <raviteja.garimella@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static
Date	2017-06-23 13:40 +0200
Message-ID	<tVv6p-1z0-9@gated-at.bofh.it> (permalink)
References	<tVuWJ-1vQ-13@gated-at.bofh.it> <tVuWK-1vQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Looks good to me.

Thanks,
Ravi

On Fri, Jun 23, 2017 at 4:50 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  snps_udc_plat.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
> index 2e11f19..f7b4d0f 100644
> --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> @@ -28,7 +28,7 @@
>  /* description */
>  #define UDC_MOD_DESCRIPTION     "Synopsys UDC platform driver"
>
> -void start_udc(struct udc *udc)
> +static void start_udc(struct udc *udc)
>  {
>         if (udc->driver) {
>                 dev_info(udc->dev, "Connecting...\n");
> @@ -38,7 +38,7 @@ void start_udc(struct udc *udc)
>         }
>  }
>
> -void stop_udc(struct udc *udc)
> +static void stop_udc(struct udc *udc)
>  {
>         int tmp;
>         u32 reg;
> @@ -76,7 +76,7 @@ void stop_udc(struct udc *udc)
>         dev_info(udc->dev, "Device disconnected\n");
>  }
>
> -void udc_drd_work(struct work_struct *work)
> +static void udc_drd_work(struct work_struct *work)
>  {
>         struct udc *udc;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[linux-next:master 6255/9581]  drivers/usb/gadget/udc/snps_udc_plat.c:31:6: sparse: symbol 'start_udc' was  not declared. Should it be static? kbuild test robot <fengguang.wu@intel.com> - 2017-06-23 13:30 +0200
  [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static kbuild test robot <fengguang.wu@intel.com> - 2017-06-23 13:30 +0200
    Re: [RFC PATCH linux-next] usb: gadget: udc: start_udc() can be static Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-06-23 13:40 +0200

csiph-web