Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673353 > unrolled thread
| Started by | Chao Yu <yuchao0@huawei.com> |
|---|---|
| First post | 2017-06-23 10:20 +0200 |
| Last post | 2017-06-24 18:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] f2fs: fix ref of discard command Chao Yu <yuchao0@huawei.com> - 2017-06-23 10:20 +0200
Re: [PATCH] f2fs: fix ref of discard command Jaegeuk Kim <jaegeuk@kernel.org> - 2017-06-24 18:30 +0200
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-06-23 10:20 +0200 |
| Subject | Re: [PATCH] f2fs: fix ref of discard command |
| Message-ID | <tVrYS-8aL-19@gated-at.bofh.it> |
Hi Jaegeuk,
On 2017/6/12 11:04, Jaegeuk Kim wrote:
> This patch resolves kernel panic for xfstests/081, caused by recent f2fs_bug_on
>
> f2fs: add f2fs_bug_on in __remove_discard_cmd
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 86a0c1095939..a6d77388a806 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1025,6 +1025,8 @@ static void __wait_discard_cmd(struct f2fs_sb_info *sbi, bool wait_cond)
> list_for_each_entry_safe(dc, tmp, wait_list, list) {
> if (!wait_cond || (dc->state == D_DONE && !dc->ref)) {
> wait_for_completion_io(&dc->wait);
> + if (dc->state == D_DONE && dc->ref)
> + dc->ref--;
How about using ("f2fs: stop discard thread in prior during umount") instead of
this one? As dereference of dc here will lead use-after-free of real referrer.
Thanks,
> __remove_discard_cmd(sbi, dc);
> } else {
> dc->ref++;
>
[toc] | [next] | [standalone]
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-06-24 18:30 +0200 |
| Message-ID | <tVW6C-1BX-13@gated-at.bofh.it> |
| In reply to | #1673353 |
On 06/23, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2017/6/12 11:04, Jaegeuk Kim wrote:
> > This patch resolves kernel panic for xfstests/081, caused by recent f2fs_bug_on
> >
> > f2fs: add f2fs_bug_on in __remove_discard_cmd
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/segment.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 86a0c1095939..a6d77388a806 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -1025,6 +1025,8 @@ static void __wait_discard_cmd(struct f2fs_sb_info *sbi, bool wait_cond)
> > list_for_each_entry_safe(dc, tmp, wait_list, list) {
> > if (!wait_cond || (dc->state == D_DONE && !dc->ref)) {
> > wait_for_completion_io(&dc->wait);
> > + if (dc->state == D_DONE && dc->ref)
> > + dc->ref--;
>
> How about using ("f2fs: stop discard thread in prior during umount") instead of
> this one? As dereference of dc here will lead use-after-free of real referrer.
Yup, I'll also verify that.
Thank you. :)
>
> Thanks,
>
> > __remove_discard_cmd(sbi, dc);
> > } else {
> > dc->ref++;
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web