Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673353

Re: [PATCH] f2fs: fix ref of discard command

Show all headers | View raw

Hi Jaegeuk,

On 2017/6/12 11:04, Jaegeuk Kim wrote:
> This patch resolves kernel panic for xfstests/081, caused by recent f2fs_bug_on
> 
>   f2fs: add f2fs_bug_on in __remove_discard_cmd
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/segment.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 86a0c1095939..a6d77388a806 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1025,6 +1025,8 @@ static void __wait_discard_cmd(struct f2fs_sb_info *sbi, bool wait_cond)
>  	list_for_each_entry_safe(dc, tmp, wait_list, list) {
>  		if (!wait_cond || (dc->state == D_DONE && !dc->ref)) {
>  			wait_for_completion_io(&dc->wait);
> +			if (dc->state == D_DONE && dc->ref)
> +				dc->ref--;

How about using ("f2fs: stop discard thread in prior during umount") instead of
this one? As dereference of dc here will lead use-after-free of real referrer.

Thanks,

>  			__remove_discard_cmd(sbi, dc);
>  		} else {
>  			dc->ref++;
> 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] f2fs: fix ref of discard command Chao Yu <yuchao0@huawei.com> - 2017-06-23 10:20 +0200
  Re: [PATCH] f2fs: fix ref of discard command Jaegeuk Kim <jaegeuk@kernel.org> - 2017-06-24 18:30 +0200

csiph-web