Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673109 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-06-23 00:50 +0200 |
| Last post | 2017-06-23 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] kdb: remove unnecessary variable assignment in kdb_bc() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-23 00:50 +0200
Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() Daniel Thompson <daniel.thompson@linaro.org> - 2017-06-23 10:10 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-23 00:50 +0200 |
| Subject | [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() |
| Message-ID | <tVj5g-2lh-19@gated-at.bofh.it> |
Value assigned to variable _bp_ at line 415 is the same as at line 434.
This makes such variable assignment unnecessary.
Addresses-Coverity-ID: 1227025
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
kernel/debug/kdb/kdb_bp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
index 90ff129..039a329e 100644
--- a/kernel/debug/kdb/kdb_bp.c
+++ b/kernel/debug/kdb/kdb_bp.c
@@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
* assume that the breakpoint number is desired.
*/
if (addr < KDB_MAXBPT) {
- bp = &kdb_breakpoints[addr];
lowbp = highbp = addr;
highbp++;
} else {
--
2.5.0
[toc] | [next] | [standalone]
| From | Daniel Thompson <daniel.thompson@linaro.org> |
|---|---|
| Date | 2017-06-23 10:10 +0200 |
| Message-ID | <tVrPc-87K-11@gated-at.bofh.it> |
| In reply to | #1673109 |
On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
>
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> kernel/debug/kdb/kdb_bp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
> * assume that the breakpoint number is desired.
> */
> if (addr < KDB_MAXBPT) {
> - bp = &kdb_breakpoints[addr];
> lowbp = highbp = addr;
> highbp++;
> } else {
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web