Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()

From	Daniel Thompson <daniel.thompson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()
Date	2017-06-23 10:10 +0200
Message-ID	<tVrPc-87K-11@gated-at.bofh.it> (permalink)
References	<tVj5g-2lh-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
> 
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

> ---
>   kernel/debug/kdb/kdb_bp.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
>   		 * assume that the breakpoint number is desired.
>   		 */
>   		if (addr < KDB_MAXBPT) {
> -			bp = &kdb_breakpoints[addr];
>   			lowbp = highbp = addr;
>   			highbp++;
>   		} else {
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kdb: remove unnecessary variable assignment in kdb_bc() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-23 00:50 +0200
  Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() Daniel Thompson <daniel.thompson@linaro.org> - 2017-06-23 10:10 +0200

csiph-web