Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672925 > unrolled thread
| Started by | Eric Anholt <eric@anholt.net> |
|---|---|
| First post | 2017-06-22 20:00 +0200 |
| Last post | 2017-06-23 20:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Eric Anholt <eric@anholt.net> - 2017-06-22 20:00 +0200
Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Philippe CORNU <philippe.cornu@st.com> - 2017-06-23 16:50 +0200
Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Eric Anholt <eric@anholt.net> - 2017-06-23 20:20 +0200
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2017-06-22 20:00 +0200 |
| Subject | [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" |
| Message-ID | <tVeyD-7Xe-31@gated-at.bofh.it> |
Signed-off-by: Eric Anholt <eric@anholt.net>
---
This fixup would be squashed into patch 1 of your series.
drivers/gpu/drm/stm/ltdc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 7d7e889f09c3..d1d28348512b 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)
bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
if (IS_ERR(bridge)) {
DRM_ERROR("Failed to create panel-bridge\n");
- return PTR_ERR(bridge);
+ ret = PTR_ERR(bridge);
+ goto err;
}
ldev->is_panel_bridge = true;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Philippe CORNU <philippe.cornu@st.com> |
|---|---|
| Date | 2017-06-23 16:50 +0200 |
| Subject | Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" |
| Message-ID | <tVy4h-3pQ-5@gated-at.bofh.it> |
| In reply to | #1672925 |
On 06/22/2017 07:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> This fixup would be squashed into patch 1 of your series.
Hi Eric,
and many thanks for the two patches, I will follow your suggestion for
the v5 serie.
By the way, do you have more comments on the "drm/stm: ltdc: Add
panel-bridge support" patch?
Many thanks :-)
Philippe
> drivers/gpu/drm/stm/ltdc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7d7e889f09c3..d1d28348512b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)
> bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
> if (IS_ERR(bridge)) {
> DRM_ERROR("Failed to create panel-bridge\n");
> - return PTR_ERR(bridge);
> + ret = PTR_ERR(bridge);
> + goto err;
> }
> ldev->is_panel_bridge = true;
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2017-06-23 20:20 +0200 |
| Message-ID | <tVBlw-5zB-5@gated-at.bofh.it> |
| In reply to | #1673614 |
[Multipart message — attachments visible in raw view] — view raw
Philippe CORNU <philippe.cornu@st.com> writes: > On 06/22/2017 07:56 PM, Eric Anholt wrote: >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- >> >> This fixup would be squashed into patch 1 of your series. > > Hi Eric, > and many thanks for the two patches, I will follow your suggestion for > the v5 serie. > By the way, do you have more comments on the "drm/stm: ltdc: Add > panel-bridge support" patch? I think that's all -- I was going to add my r-b and apply that one, when I found this little nitpick.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web