Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1673614

Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"

From Philippe CORNU <philippe.cornu@st.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"
Date 2017-06-23 16:50 +0200
Message-ID <tVy4h-3pQ-5@gated-at.bofh.it> (permalink)
References <tVeyD-7Xe-33@gated-at.bofh.it> <tVeyD-7Xe-35@gated-at.bofh.it> <tVeyD-7Xe-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 06/22/2017 07:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> 
> This fixup would be squashed into patch 1 of your series.

Hi Eric,
and many thanks for the two patches, I will follow your suggestion for 
the v5 serie.
By the way, do you have more comments on the "drm/stm: ltdc: Add 
panel-bridge support" patch?
Many thanks :-)
Philippe

>   drivers/gpu/drm/stm/ltdc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7d7e889f09c3..d1d28348512b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)
>   		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
>   		if (IS_ERR(bridge)) {
>   			DRM_ERROR("Failed to create panel-bridge\n");
> -			return PTR_ERR(bridge);
> +			ret = PTR_ERR(bridge);
> +			goto err;
>   		}
>   		ldev->is_panel_bridge = true;
>   	}
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Eric Anholt <eric@anholt.net> - 2017-06-22 20:00 +0200
  Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge  support" Philippe CORNU <philippe.cornu@st.com> - 2017-06-23 16:50 +0200
    Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Eric Anholt <eric@anholt.net> - 2017-06-23 20:20 +0200

csiph-web