Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672121 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-22 00:20 +0200 |
| Last post | 2017-06-22 16:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: es8316: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:20 +0200
Re: [PATCH] ASoC: es8316: add I2C dependency Daniel Drake <drake@endlessm.com> - 2017-06-22 15:20 +0200
Applied "ASoC: es8316: add I2C dependency" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-06-22 16:20 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-22 00:20 +0200 |
| Subject | [PATCH] ASoC: es8316: add I2C dependency |
| Message-ID | <tUW8F-3Zg-5@gated-at.bofh.it> |
Without CONFIG_I2C, we get a build failure:
sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
This adds the required Kconfig dependency.
Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
config SND_SOC_ES8316
tristate "Everest Semi ES8316 CODEC"
+ depends on I2C
config SND_SOC_ES8328
tristate
--
2.9.0
[toc] | [next] | [standalone]
| From | Daniel Drake <drake@endlessm.com> |
|---|---|
| Date | 2017-06-22 15:20 +0200 |
| Message-ID | <tVabD-5es-1@gated-at.bofh.it> |
| In reply to | #1672121 |
On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Without CONFIG_I2C, we get a build failure:
>
> sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
> sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
>
> This adds the required Kconfig dependency.
>
> Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Drake <drake@endlessm.com>
Thanks for the patch.
> ---
> sound/soc/codecs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c6286e5ba511..f0f794186186 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -546,6 +546,7 @@ config SND_SOC_ES7134
>
> config SND_SOC_ES8316
> tristate "Everest Semi ES8316 CODEC"
> + depends on I2C
>
> config SND_SOC_ES8328
> tristate
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-06-22 16:20 +0200 |
| Subject | Applied "ASoC: es8316: add I2C dependency" to the asoc tree |
| Message-ID | <tVb7H-5Qr-11@gated-at.bofh.it> |
| In reply to | #1672121 |
The patch
ASoC: es8316: add I2C dependency
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 664d00d187608c66904e62ff2f24e7df49611ba5 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 22 Jun 2017 00:09:23 +0200
Subject: [PATCH] ASoC: es8316: add I2C dependency
Without CONFIG_I2C, we get a build failure:
sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
This adds the required Kconfig dependency.
Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
config SND_SOC_ES8316
tristate "Everest Semi ES8316 CODEC"
+ depends on I2C
config SND_SOC_ES8328
tristate
--
2.11.0
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web