Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672615

Re: [PATCH] ASoC: es8316: add I2C dependency

Show all headers | View raw

On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Without CONFIG_I2C, we get a build failure:
>
> sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
> sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
>
> This adds the required Kconfig dependency.
>
> Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Daniel Drake <drake@endlessm.com>

Thanks for the patch.

> ---
>  sound/soc/codecs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c6286e5ba511..f0f794186186 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -546,6 +546,7 @@ config SND_SOC_ES7134
>
>  config SND_SOC_ES8316
>         tristate "Everest Semi ES8316 CODEC"
> +       depends on I2C
>
>  config SND_SOC_ES8328
>         tristate
> --
> 2.9.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: es8316: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:20 +0200
  Re: [PATCH] ASoC: es8316: add I2C dependency Daniel Drake <drake@endlessm.com> - 2017-06-22 15:20 +0200
  Applied "ASoC: es8316: add I2C dependency" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-06-22 16:20 +0200

csiph-web