Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673804 > unrolled thread
| Started by | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| First post | 2017-06-23 21:50 +0200 |
| Last post | 2017-07-01 05:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-23 21:50 +0200
Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' Stefan Wahren <stefan.wahren@i2se.com> - 2017-06-23 22:30 +0200
Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' Eduardo Valentin <edubezval@gmail.com> - 2017-07-01 05:00 +0200
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Date | 2017-06-23 21:50 +0200 |
| Subject | [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' |
| Message-ID | <tVCKC-6lJ-23@gated-at.bofh.it> |
'tz' is a valid pointer at this point, so calling PTR_ERR on it is
pointless.
This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above.
So remove it. 'err' is already the error we want to report.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: fix empty subject
---
drivers/thermal/broadcom/bcm2835_thermal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 0ecf80890c84..e6863c841662 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -245,7 +245,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
*/
err = tz->ops->get_trip_temp(tz, 0, &trip_temp);
if (err < 0) {
- err = PTR_ERR(tz);
dev_err(&pdev->dev,
"Not able to read trip_temp: %d\n",
err);
--
2.11.0
[toc] | [next] | [standalone]
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Date | 2017-06-23 22:30 +0200 |
| Subject | Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' |
| Message-ID | <tVDnl-6P1-51@gated-at.bofh.it> |
| In reply to | #1673804 |
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> hat am 23. Juni 2017 um 21:44 geschrieben: > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > pointless. > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > So remove it. 'err' is already the error we want to report. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks, but Dan Carpenter already send a fix for this.
[toc] | [prev] | [next] | [standalone]
| From | Eduardo Valentin <edubezval@gmail.com> |
|---|---|
| Date | 2017-07-01 05:00 +0200 |
| Subject | Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' |
| Message-ID | <tYgNz-5oD-5@gated-at.bofh.it> |
| In reply to | #1673843 |
On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote: > > > Christophe JAILLET <christophe.jaillet@wanadoo.fr> hat am 23. Juni 2017 um 21:44 geschrieben: > > > > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > > pointless. > > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > > So remove it. 'err' is already the error we want to report. > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Thanks, but Dan Carpenter already send a fix for this. Yeah, and I applied Dan's version as it was coming first in my queue. Sorry.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web