[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'
Date	2017-06-23 21:50 +0200
Message-ID	<tVCKC-6lJ-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

'tz' is a valid pointer at this point, so calling PTR_ERR on it is
pointless.
This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above.
So remove it. 'err' is already the error we want to report.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: fix empty subject
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 0ecf80890c84..e6863c841662 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -245,7 +245,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 		 */
 		err = tz->ops->get_trip_temp(tz, 0, &trip_temp);
 		if (err < 0) {
-			err = PTR_ERR(tz);
 			dev_err(&pdev->dev,
 				"Not able to read trip_temp: %d\n",
 				err);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-23 21:50 +0200
  Re: [PATCH v2] thermal: bcm2835: Fix error code in  'bcm2835_thermal_probe' Stefan Wahren <stefan.wahren@i2se.com> - 2017-06-23 22:30 +0200
    Re: [PATCH v2] thermal: bcm2835: Fix error code in  'bcm2835_thermal_probe' Eduardo Valentin <edubezval@gmail.com> - 2017-07-01 05:00 +0200

csiph-web