Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672381 > unrolled thread

Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation Jiri Slaby <jslaby@suse.cz> - 2017-06-22 09:50 +0200
    Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-22 15:00 +0200

#1672381 — Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation

On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> I agree with all your comments, will fix them all.  Thanks for the
> review.

This is not the correct way:
++      if (flags & O_WRONLY)
++              cmd = ELF_C_WRITE;
++      else if (flags & O_RDWR)
++              cmd = ELF_C_RDWR;
++      else
++              cmd = ELF_C_READ_MMAP;

For this particular codeflow, it works, but it should be:
(flags & O_ACCMODE) == O_WRONLY
                    == O_RDWR

thanks,
-- 
js
suse labs

[toc] | [next] | [standalone]

#1672608

On Thu, Jun 22, 2017 at 09:47:46AM +0200, Jiri Slaby wrote:
> On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> > I agree with all your comments, will fix them all.  Thanks for the
> > review.
> 
> This is not the correct way:
> ++      if (flags & O_WRONLY)
> ++              cmd = ELF_C_WRITE;
> ++      else if (flags & O_RDWR)
> ++              cmd = ELF_C_RDWR;
> ++      else
> ++              cmd = ELF_C_READ_MMAP;
> 
> For this particular codeflow, it works, but it should be:
> (flags & O_ACCMODE) == O_WRONLY
>                     == O_RDWR

Ok, thanks.  I see you started reviewing v2 early ;-)  It's almost ready
to post, will send the patches next week.

-- 
Josh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web