Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1671074 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-20 22:20 +0200 |
| Last post | 2017-06-23 02:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:20 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Stephen Boyd <sboyd@codeaurora.org> - 2017-06-22 00:00 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Tero Kristo <t-kristo@ti.com> - 2017-06-22 08:10 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Stephen Boyd <sboyd@codeaurora.org> - 2017-06-23 02:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-20 22:20 +0200 |
| Subject | [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver |
| Message-ID | <tUxN1-4P5-43@gated-at.bofh.it> |
CONFIG_COMPILE_TEST allows building a configuration without
TI_SCI_PROTOCOL, which then fails to link:
drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
This makes it a hard dependency. Right now, that means we can't
actually compile-test the driver unless ARCH_KEYSTONE is set as
well, but we can fix that by allowing TI_MESSAGE_MANAGER to
be selected for COMPILE_TEST as well.
Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/keystone/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/keystone/Kconfig b/drivers/clk/keystone/Kconfig
index 1fea328a36fe..7e9f0176578a 100644
--- a/drivers/clk/keystone/Kconfig
+++ b/drivers/clk/keystone/Kconfig
@@ -8,7 +8,8 @@ config COMMON_CLK_KEYSTONE
config TI_SCI_CLK
tristate "TI System Control Interface clock drivers"
depends on (ARCH_KEYSTONE || COMPILE_TEST) && OF
- default TI_SCI_PROTOCOL
+ depends on TI_SCI_PROTOCOL
+ default ARCH_KEYSTONE
---help---
This adds the clock driver support over TI System Control Interface.
If you wish to use clock resources from the PMMC firmware, say Y.
--
2.9.0
[toc] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-06-22 00:00 +0200 |
| Message-ID | <tUVPl-3BI-35@gated-at.bofh.it> |
| In reply to | #1671074 |
On 06/20, Arnd Bergmann wrote:
> CONFIG_COMPILE_TEST allows building a configuration without
> TI_SCI_PROTOCOL, which then fails to link:
>
> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>
> This makes it a hard dependency. Right now, that means we can't
> actually compile-test the driver unless ARCH_KEYSTONE is set as
> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
> be selected for COMPILE_TEST as well.
>
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Looks ok to me. Tero?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Tero Kristo <t-kristo@ti.com> |
|---|---|
| Date | 2017-06-22 08:10 +0200 |
| Message-ID | <tV3tw-H8-5@gated-at.bofh.it> |
| In reply to | #1672104 |
On 22/06/17 00:50, Stephen Boyd wrote:
> On 06/20, Arnd Bergmann wrote:
>> CONFIG_COMPILE_TEST allows building a configuration without
>> TI_SCI_PROTOCOL, which then fails to link:
>>
>> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
>> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>>
>> This makes it a hard dependency. Right now, that means we can't
>> actually compile-test the driver unless ARCH_KEYSTONE is set as
>> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
>> be selected for COMPILE_TEST as well.
>>
>> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>
> Looks ok to me. Tero?
>
Yeah, looks okay to me also, been traveling so sorry about the latency.
Acked-by: Tero Kristo <t-kristo@ti.com>
[toc] | [prev] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-06-23 02:40 +0200 |
| Message-ID | <tVkNH-3sv-1@gated-at.bofh.it> |
| In reply to | #1671074 |
On 06/20, Arnd Bergmann wrote:
> CONFIG_COMPILE_TEST allows building a configuration without
> TI_SCI_PROTOCOL, which then fails to link:
>
> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>
> This makes it a hard dependency. Right now, that means we can't
> actually compile-test the driver unless ARCH_KEYSTONE is set as
> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
> be selected for COMPILE_TEST as well.
>
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web