Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672320
| From | Tero Kristo <t-kristo@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver |
| Date | 2017-06-22 08:10 +0200 |
| Message-ID | <tV3tw-H8-5@gated-at.bofh.it> (permalink) |
| References | <tUxN1-4P5-43@gated-at.bofh.it> <tUVPl-3BI-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 22/06/17 00:50, Stephen Boyd wrote:
> On 06/20, Arnd Bergmann wrote:
>> CONFIG_COMPILE_TEST allows building a configuration without
>> TI_SCI_PROTOCOL, which then fails to link:
>>
>> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
>> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>>
>> This makes it a hard dependency. Right now, that means we can't
>> actually compile-test the driver unless ARCH_KEYSTONE is set as
>> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
>> be selected for COMPILE_TEST as well.
>>
>> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>
> Looks ok to me. Tero?
>
Yeah, looks okay to me also, been traveling so sorry about the latency.
Acked-by: Tero Kristo <t-kristo@ti.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:20 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Stephen Boyd <sboyd@codeaurora.org> - 2017-06-22 00:00 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Tero Kristo <t-kristo@ti.com> - 2017-06-22 08:10 +0200
Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver Stephen Boyd <sboyd@codeaurora.org> - 2017-06-23 02:40 +0200
csiph-web