Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1670761 > unrolled thread

Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset

Started byChristoph Hellwig <hch@infradead.org>
First post2017-06-20 15:30 +0200
Last post2017-06-22 14:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset Christoph Hellwig <hch@infradead.org> - 2017-06-20 15:30 +0200
    Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-22 14:50 +0200

#1670761 — Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset

FromChristoph Hellwig <hch@infradead.org>
Date2017-06-20 15:30 +0200
SubjectRe: [PATCH v5 1/7] dma: Take into account dma_pfn_offset
Message-ID<tUroe-Jj-33@gated-at.bofh.it>
> -		sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
> +		sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));

Needs a line break instead of the overly long line.

Otherwise this looks fine to me.

[toc] | [next] | [standalone]


#1672603

FromVladimir Murzin <vladimir.murzin@arm.com>
Date2017-06-22 14:50 +0200
Message-ID<tV9IC-4Lr-27@gated-at.bofh.it>
In reply to#1670761
On 20/06/17 14:24, Christoph Hellwig wrote:
>> -		sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
>> +		sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));
> 
> Needs a line break instead of the overly long line.

Will do.

> 
> Otherwise this looks fine to me.
> 

Thanks
Vladimir

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web