Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset

From	Vladimir Murzin <vladimir.murzin@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset
Date	2017-06-22 14:50 +0200
Message-ID	<tV9IC-4Lr-27@gated-at.bofh.it> (permalink)
References	<tKBIe-15d-7@gated-at.bofh.it> <tKCkW-1Ap-33@gated-at.bofh.it> <tUroe-Jj-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/06/17 14:24, Christoph Hellwig wrote:
>> -		sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
>> +		sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));
> 
> Needs a line break instead of the overly long line.

Will do.

> 
> Otherwise this looks fine to me.
> 

Thanks
Vladimir

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset Christoph Hellwig <hch@infradead.org> - 2017-06-20 15:30 +0200
  Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-22 14:50 +0200

csiph-web