Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670648 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-20 12:30 +0200 |
| Last post | 2017-06-20 17:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][tpm-next] tpm_tis: make ilb_base_addr static Colin King <colin.king@canonical.com> - 2017-06-20 12:30 +0200
Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-06-20 17:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-20 12:30 +0200 |
| Subject | [PATCH][tpm-next] tpm_tis: make ilb_base_addr static |
| Message-ID | <tUoA2-7os-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The pointer ilb_base_addr does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'ilb_base_addr' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 506e62ca3576..c915d65c1909 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
#define LPC_CNTRL_REG_OFFSET 0x84
#define LPC_CLKRUN_EN (1 << 2)
-void __iomem *ilb_base_addr;
+static void __iomem *ilb_base_addr;
static inline bool is_bsw(void)
{
--
2.11.0
[toc] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-06-20 17:10 +0200 |
| Message-ID | <tUsWZ-1Ny-9@gated-at.bofh.it> |
| In reply to | #1670648 |
On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer ilb_base_addr does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'ilb_base_addr' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 506e62ca3576..c915d65c1909 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
> #define LPC_CNTRL_REG_OFFSET 0x84
> #define LPC_CLKRUN_EN (1 << 2)
>
> -void __iomem *ilb_base_addr;
> +static void __iomem *ilb_base_addr;
>
> static inline bool is_bsw(void)
> {
> --
> 2.11.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web