Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670648

[PATCH][tpm-next] tpm_tis: make ilb_base_addr static

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The pointer ilb_base_addr does not need to be in global scope, so make
it static.

Cleans up sparse warning:
"symbol 'ilb_base_addr' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 506e62ca3576..c915d65c1909 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
 #define LPC_CNTRL_REG_OFFSET            0x84
 #define LPC_CLKRUN_EN                   (1 << 2)
 
-void __iomem *ilb_base_addr;
+static void __iomem *ilb_base_addr;
 
 static inline bool is_bsw(void)
 {
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][tpm-next] tpm_tis: make ilb_base_addr static Colin King <colin.king@canonical.com> - 2017-06-20 12:30 +0200
  Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-06-20 17:10 +0200

csiph-web