Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1668210 > unrolled thread

tty: define tty_open_by_driver when CONFIG_TTY is not defined

Started byOkash Khawaja <okash.khawaja@gmail.com>
First post2017-06-17 11:50 +0200
Last post2017-06-19 23:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  tty: define tty_open_by_driver when CONFIG_TTY is not defined Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-17 11:50 +0200
    Re: tty: define tty_open_by_driver when CONFIG_TTY is not defined Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-06-17 23:10 +0200
      [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not  defined Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-17 23:40 +0200
        Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not  defined Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-06-19 23:30 +0200

#1668210 — tty: define tty_open_by_driver when CONFIG_TTY is not defined

FromOkash Khawaja <okash.khawaja@gmail.com>
Date2017-06-17 11:50 +0200
Subjecttty: define tty_open_by_driver when CONFIG_TTY is not defined
Message-ID<tTiwF-5hF-7@gated-at.bofh.it>
This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
defined. This was supposed to have been included in commit
12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
tty_open_by_driver"). The patch follows convention for other such
functions and returns NULL.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

---
 include/linux/tty.h |    3 +++
 1 file changed, 3 insertions(+)

--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
 { return 0; }
 static inline const char *tty_name(const struct tty_struct *tty)
 { return "(none)"; }
+static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+		struct file *filp)
+{ return NULL; }
 #endif
 
 extern struct ktermios tty_std_termios;

[toc] | [next] | [standalone]


#1668394

FromSamuel Thibault <samuel.thibault@ens-lyon.org>
Date2017-06-17 23:10 +0200
Message-ID<tTt8J-4iR-5@gated-at.bofh.it>
In reply to#1668210
Okash Khawaja, on sam. 17 juin 2017 10:46:41 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> 
> ---
>  include/linux/tty.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
>  { return 0; }
>  static inline const char *tty_name(const struct tty_struct *tty)
>  { return "(none)"; }
> +static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
> +		struct file *filp)
> +{ return NULL; }

Add inline

Samuel

[toc] | [prev] | [next] | [standalone]


#1668398 — [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined

FromOkash Khawaja <okash.khawaja@gmail.com>
Date2017-06-17 23:40 +0200
Subject[patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined
Message-ID<tTtBM-4x1-5@gated-at.bofh.it>
In reply to#1668394
This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
defined. This was supposed to have been included in commit
12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
tty_open_by_driver"). The patch follows convention for other such
functions and returns NULL.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

---
 include/linux/tty.h |    3 +++
 1 file changed, 3 insertions(+)

--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -422,6 +422,9 @@ static inline int __init tty_init(void)
 { return 0; }
 static inline const char *tty_name(const struct tty_struct *tty)
 { return "(none)"; }
+static inline struct tty_struct *tty_open_by_driver(dev_t device,
+		struct inode *inode, struct file *filp)
+{ return NULL; }
 #endif
 
 extern struct ktermios tty_std_termios;

[toc] | [prev] | [next] | [standalone]


#1669965 — Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined

FromSamuel Thibault <samuel.thibault@ens-lyon.org>
Date2017-06-19 23:30 +0200
SubjectRe: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined
Message-ID<tUcpb-83n-7@gated-at.bofh.it>
In reply to#1668398
Okash Khawaja, on sam. 17 juin 2017 22:32:55 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> 
> ---
>  include/linux/tty.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
>  { return 0; }
>  static inline const char *tty_name(const struct tty_struct *tty)
>  { return "(none)"; }
> +static inline struct tty_struct *tty_open_by_driver(dev_t device,
> +		struct inode *inode, struct file *filp)
> +{ return NULL; }
>  #endif
>  
>  extern struct ktermios tty_std_termios;
> 

-- 
Samuel
<O> Ça peut être une madeleine à sous munitions (avec des composants,
par exemple)
 -+- #runtime -+-

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web