Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined

From	Samuel Thibault <samuel.thibault@ens-lyon.org>
Newsgroups	linux.kernel
Subject	Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not defined
Date	2017-06-19 23:30 +0200
Message-ID	<tUcpb-83n-7@gated-at.bofh.it> (permalink)
References	<tTt8J-4iR-5@gated-at.bofh.it> <tTtBM-4x1-5@gated-at.bofh.it>
Organization	I am not organized

Show all headers | View raw

Okash Khawaja, on sam. 17 juin 2017 22:32:55 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> 
> ---
>  include/linux/tty.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
>  { return 0; }
>  static inline const char *tty_name(const struct tty_struct *tty)
>  { return "(none)"; }
> +static inline struct tty_struct *tty_open_by_driver(dev_t device,
> +		struct inode *inode, struct file *filp)
> +{ return NULL; }
>  #endif
>  
>  extern struct ktermios tty_std_termios;
> 

-- 
Samuel
<O> Ça peut être une madeleine à sous munitions (avec des composants,
par exemple)
 -+- #runtime -+-

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

tty: define tty_open_by_driver when CONFIG_TTY is not defined Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-17 11:50 +0200
  Re: tty: define tty_open_by_driver when CONFIG_TTY is not defined Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-06-17 23:10 +0200
    [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not  defined Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-17 23:40 +0200
      Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not  defined Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-06-19 23:30 +0200

csiph-web