Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672047 > unrolled thread
| Started by | Tahsin Erdogan <tahsin@google.com> |
|---|---|
| First post | 2017-06-21 23:30 +0200 |
| Last post | 2017-06-22 04:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 16/32] ext4: fix ext4_xattr_cmp() Tahsin Erdogan <tahsin@google.com> - 2017-06-21 23:30 +0200
Re: [PATCH 16/32] ext4: fix ext4_xattr_cmp() Theodore Ts'o <tytso@mit.edu> - 2017-06-22 04:20 +0200
| From | Tahsin Erdogan <tahsin@google.com> |
|---|---|
| Date | 2017-06-21 23:30 +0200 |
| Subject | [PATCH 16/32] ext4: fix ext4_xattr_cmp() |
| Message-ID | <tUVmi-3od-21@gated-at.bofh.it> |
When a xattr entry refers to an external inode, the value data is not available in the inline area so we should not attempt to read it using value offset. Signed-off-by: Tahsin Erdogan <tahsin@google.com> --- fs/ext4/xattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 9c243b3510b7..739f73a5a345 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2169,7 +2169,8 @@ ext4_xattr_cmp(struct ext4_xattr_header *header1, entry1->e_value_inum != entry2->e_value_inum || memcmp(entry1->e_name, entry2->e_name, entry1->e_name_len)) return 1; - if (memcmp((char *)header1 + le16_to_cpu(entry1->e_value_offs), + if (!entry1->e_value_inum && + memcmp((char *)header1 + le16_to_cpu(entry1->e_value_offs), (char *)header2 + le16_to_cpu(entry2->e_value_offs), le32_to_cpu(entry1->e_value_size))) return 1; -- 2.13.1.611.g7e3b11ae1-goog
[toc] | [next] | [standalone]
| From | Theodore Ts'o <tytso@mit.edu> |
|---|---|
| Date | 2017-06-22 04:20 +0200 |
| Message-ID | <tUZSW-6En-3@gated-at.bofh.it> |
| In reply to | #1672047 |
On Wed, Jun 21, 2017 at 02:21:26PM -0700, Tahsin Erdogan wrote: > When a xattr entry refers to an external inode, the value data is not > available in the inline area so we should not attempt to read it using > value offset. > > Signed-off-by: Tahsin Erdogan <tahsin@google.com> Thanks, added to the ext4 patch queue. - Ted
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web