Groups > linux.kernel > #1672047

[PATCH 16/32] ext4: fix ext4_xattr_cmp()

From	Tahsin Erdogan <tahsin@google.com>
Newsgroups	linux.kernel
Subject	[PATCH 16/32] ext4: fix ext4_xattr_cmp()
Date	2017-06-21 23:30 +0200
Message-ID	<tUVmi-3od-21@gated-at.bofh.it> (permalink)
References	<tUVmh-3od-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When a xattr entry refers to an external inode, the value data is not
available in the inline area so we should not attempt to read it using
value offset.

Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
 fs/ext4/xattr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 9c243b3510b7..739f73a5a345 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2169,7 +2169,8 @@ ext4_xattr_cmp(struct ext4_xattr_header *header1,
 		    entry1->e_value_inum != entry2->e_value_inum ||
 		    memcmp(entry1->e_name, entry2->e_name, entry1->e_name_len))
 			return 1;
-		if (memcmp((char *)header1 + le16_to_cpu(entry1->e_value_offs),
+		if (!entry1->e_value_inum &&
+		    memcmp((char *)header1 + le16_to_cpu(entry1->e_value_offs),
 			   (char *)header2 + le16_to_cpu(entry2->e_value_offs),
 			   le32_to_cpu(entry1->e_value_size)))
 			return 1;
-- 
2.13.1.611.g7e3b11ae1-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 16/32] ext4: fix ext4_xattr_cmp() Tahsin Erdogan <tahsin@google.com> - 2017-06-21 23:30 +0200
  Re: [PATCH 16/32] ext4: fix ext4_xattr_cmp() Theodore Ts'o <tytso@mit.edu> - 2017-06-22 04:20 +0200

csiph-web