Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672109 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-22 00:10 +0200 |
| Last post | 2017-06-26 00:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ata: ftide010: fix resource printing Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:10 +0200
Re: [PATCH] ata: ftide010: fix resource printing Tejun Heo <tj@kernel.org> - 2017-06-22 00:10 +0200
Re: [PATCH] ata: ftide010: fix resource printing Linus Walleij <linus.walleij@linaro.org> - 2017-06-26 00:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-22 00:10 +0200 |
| Subject | [PATCH] ata: ftide010: fix resource printing |
| Message-ID | <tUVZ0-3Vj-9@gated-at.bofh.it> |
The new driver uses an incorrect format string for resource_size_t:
drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
The nicest way to print the address is to pretty-print the resource
using %pR.
Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/pata_ftide010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
index 7b7e417ba8ba..5d4b72e21161 100644
--- a/drivers/ata/pata_ftide010.c
+++ b/drivers/ata/pata_ftide010.c
@@ -517,8 +517,8 @@ static int pata_ftide010_probe(struct platform_device *pdev)
ata_sff_std_ports(ioaddr);
}
- dev_info(dev, "device ID %08x, irq %d, io base 0x%08x\n",
- readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res->start);
+ dev_info(dev, "device ID %08x, irq %d, reg %pR\n",
+ readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res);
ret = ata_host_activate(ftide->host, irq, ata_bmdma_interrupt,
0, &pata_ftide010_sht);
--
2.9.0
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2017-06-22 00:10 +0200 |
| Message-ID | <tUVZ1-3Vj-25@gated-at.bofh.it> |
| In reply to | #1672109 |
On Thu, Jun 22, 2017 at 12:00:55AM +0200, Arnd Bergmann wrote:
> The new driver uses an incorrect format string for resource_size_t:
>
> drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
> drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> The nicest way to print the address is to pretty-print the resource
> using %pR.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to libata/for-4.13.
Thanks.
--
Tejun
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-06-26 00:10 +0200 |
| Message-ID | <tWnTb-2hR-7@gated-at.bofh.it> |
| In reply to | #1672109 |
On Thu, Jun 22, 2017 at 12:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new driver uses an incorrect format string for resource_size_t:
>
> drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
> drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> The nicest way to print the address is to pretty-print the resource
> using %pR.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web