Re: [PATCH] ata: ftide010: fix resource printing

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ata: ftide010: fix resource printing
Date	2017-06-26 00:10 +0200
Message-ID	<tWnTb-2hR-7@gated-at.bofh.it> (permalink)
References	<tUVZ0-3Vj-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 22, 2017 at 12:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> The new driver uses an incorrect format string for resource_size_t:
>
> drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
> drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> The nicest way to print the address is to pretty-print the resource
> using %pR.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ata: ftide010: fix resource printing Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:10 +0200
  Re: [PATCH] ata: ftide010: fix resource printing Tejun Heo <tj@kernel.org> - 2017-06-22 00:10 +0200
  Re: [PATCH] ata: ftide010: fix resource printing Linus Walleij <linus.walleij@linaro.org> - 2017-06-26 00:10 +0200

csiph-web