Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669162 > unrolled thread
| Started by | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| First post | 2017-06-19 17:00 +0200 |
| Last post | 2017-06-19 18:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 17:00 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:00 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 18:10 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:20 +0200
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Date | 2017-06-19 17:00 +0200 |
| Subject | Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support |
| Message-ID | <tU6jN-3YD-51@gated-at.bofh.it> |
On 07/06/2017 10:19, Marc Gonzalez wrote:
> On 31/05/2017 15:33, Marc Gonzalez wrote:
>
>> +static int tango_pcie_probe(struct platform_device *pdev)
>> +{
>> + int ret = -EINVAL;
>> + void __iomem *base;
>> + struct resource *res;
>> + struct tango_pcie *pcie;
>> + struct device *dev = &pdev->dev;
>> +
>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>
> Hello Bjorn,
>
> In v4, your only comment was
> "[muxing config and mem spaces] is a major issue and possibly even
> a security problem [which requires at least an error message and a
> kernel taint].
>
> Were there any other issues with the host bridge support?
Hello Bjorn,
I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
(AFAIU, all issues have been addressed as of v8 3/3.)
Rob has Acked patch 1/3 -- thanks Rob.
Assuming all issues with patch 2/3 have already been addressed,
then this driver can land in time for 4.13 right?
Regards.
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2017-06-19 18:00 +0200 |
| Message-ID | <tU7fR-4Bo-29@gated-at.bofh.it> |
| In reply to | #1669162 |
On 19/06/17 15:50, Marc Gonzalez wrote:
> On 07/06/2017 10:19, Marc Gonzalez wrote:
>
>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>
>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>> +{
>>> + int ret = -EINVAL;
>>> + void __iomem *base;
>>> + struct resource *res;
>>> + struct tango_pcie *pcie;
>>> + struct device *dev = &pdev->dev;
>>> +
>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>
>> Hello Bjorn,
>>
>> In v4, your only comment was
>> "[muxing config and mem spaces] is a major issue and possibly even
>> a security problem [which requires at least an error message and a
>> kernel taint].
>>
>> Were there any other issues with the host bridge support?
>
> Hello Bjorn,
>
> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
> (AFAIU, all issues have been addressed as of v8 3/3.)
Posting partial series is really not ideal, specially as you posted 3 of
them in less than 24 hours (and the latest was only 5 days ago).
The maintainer is not going to chase you about potentially missing
patches...
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [next] | [standalone]
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Date | 2017-06-19 18:10 +0200 |
| Message-ID | <tU7py-4Ul-53@gated-at.bofh.it> |
| In reply to | #1669388 |
On 19/06/2017 17:58, Marc Zyngier wrote:
> On 19/06/17 15:50, Marc Gonzalez wrote:
>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>
>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>
>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>> +{
>>>> + int ret = -EINVAL;
>>>> + void __iomem *base;
>>>> + struct resource *res;
>>>> + struct tango_pcie *pcie;
>>>> + struct device *dev = &pdev->dev;
>>>> +
>>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>
>>> Hello Bjorn,
>>>
>>> In v4, your only comment was
>>> "[muxing config and mem spaces] is a major issue and possibly even
>>> a security problem [which requires at least an error message and a
>>> kernel taint].
>>>
>>> Were there any other issues with the host bridge support?
>>
>> Hello Bjorn,
>>
>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>> (AFAIU, all issues have been addressed as of v8 3/3.)
>
> Posting partial series is really not ideal, specially as you posted 3 of
> them in less than 24 hours (and the latest was only 5 days ago).
>
> The maintainer is not going to chase you about potentially missing
> patches...
So the best course would be posting a new series with all patches
bumped to v8 then?
Regards.
[toc] | [prev] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2017-06-19 18:20 +0200 |
| Message-ID | <tU7zd-4Y3-29@gated-at.bofh.it> |
| In reply to | #1669413 |
On 19/06/17 17:01, Marc Gonzalez wrote:
> On 19/06/2017 17:58, Marc Zyngier wrote:
>> On 19/06/17 15:50, Marc Gonzalez wrote:
>>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>>
>>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>>
>>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>>> +{
>>>>> + int ret = -EINVAL;
>>>>> + void __iomem *base;
>>>>> + struct resource *res;
>>>>> + struct tango_pcie *pcie;
>>>>> + struct device *dev = &pdev->dev;
>>>>> +
>>>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>>
>>>> Hello Bjorn,
>>>>
>>>> In v4, your only comment was
>>>> "[muxing config and mem spaces] is a major issue and possibly even
>>>> a security problem [which requires at least an error message and a
>>>> kernel taint].
>>>>
>>>> Were there any other issues with the host bridge support?
>>>
>>> Hello Bjorn,
>>>
>>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>>> (AFAIU, all issues have been addressed as of v8 3/3.)
>>
>> Posting partial series is really not ideal, specially as you posted 3 of
>> them in less than 24 hours (and the latest was only 5 days ago).
>>
>> The maintainer is not going to chase you about potentially missing
>> patches...
>
> So the best course would be posting a new series with all patches
> bumped to v8 then?
No, because there is still the ambiguity of *which* v8 that is. Post a
v9 that supersedes all the previously posted patches.
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web