Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669413
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support |
| Date | 2017-06-19 18:10 +0200 |
| Message-ID | <tU7py-4Ul-53@gated-at.bofh.it> (permalink) |
| References | <tNcki-5yl-5@gated-at.bofh.it> <tNcki-5yl-3@gated-at.bofh.it> <tPEvL-47A-21@gated-at.bofh.it> <tU6jN-3YD-51@gated-at.bofh.it> <tU7fR-4Bo-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 19/06/2017 17:58, Marc Zyngier wrote:
> On 19/06/17 15:50, Marc Gonzalez wrote:
>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>
>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>
>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>> +{
>>>> + int ret = -EINVAL;
>>>> + void __iomem *base;
>>>> + struct resource *res;
>>>> + struct tango_pcie *pcie;
>>>> + struct device *dev = &pdev->dev;
>>>> +
>>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>
>>> Hello Bjorn,
>>>
>>> In v4, your only comment was
>>> "[muxing config and mem spaces] is a major issue and possibly even
>>> a security problem [which requires at least an error message and a
>>> kernel taint].
>>>
>>> Were there any other issues with the host bridge support?
>>
>> Hello Bjorn,
>>
>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>> (AFAIU, all issues have been addressed as of v8 3/3.)
>
> Posting partial series is really not ideal, specially as you posted 3 of
> them in less than 24 hours (and the latest was only 5 days ago).
>
> The maintainer is not going to chase you about potentially missing
> patches...
So the best course would be posting a new series with all patches
bumped to v8 then?
Regards.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 17:00 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:00 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 18:10 +0200
Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:20 +0200
csiph-web