Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665666 > unrolled thread

Re: [PATCH] fbdev: avoid int-in-bool-context warning

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] fbdev: avoid int-in-bool-context warning Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-06-14 12:10 +0200

#1665666 — Re: [PATCH] fbdev: avoid int-in-bool-context warning

On Thursday, May 11, 2017 02:47:01 PM Arnd Bergmann wrote:
> gcc-7 suspects this code might be wrong because we use the
> result of a multiplication as a bool:
> 
> drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_add_monspecs':
> drivers/video/fbdev/core/fbmon.c:1051:84: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
> 
> It's actually fine, so let's add a comparison to zero to make
> that clear to the compiler too.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web