Re: [PATCH] fbdev: avoid int-in-bool-context warning

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fbdev: avoid int-in-bool-context warning
Date	2017-06-14 12:10 +0200
Message-ID	<tSdpn-3Qa-7@gated-at.bofh.it> (permalink)
References	<tSdpn-3Qa-9@gated-at.bofh.it> <tFVHz-6lJ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday, May 11, 2017 02:47:01 PM Arnd Bergmann wrote:
> gcc-7 suspects this code might be wrong because we use the
> result of a multiplication as a bool:
> 
> drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_add_monspecs':
> drivers/video/fbdev/core/fbmon.c:1051:84: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
> 
> It's actually fine, so let's add a comparison to zero to make
> that clear to the compiler too.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] fbdev: avoid int-in-bool-context warning Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-06-14 12:10 +0200

csiph-web