Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664339 > unrolled thread

[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

Started byHoeun Ryu <hoeun.ryu@gmail.com>
First post2017-06-13 03:20 +0200
Last post2017-06-14 09:30 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-13 03:20 +0200
    [RESEND PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-13 03:20 +0200
    Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Tony Lindgren <tony@atomide.com> - 2017-06-14 07:30 +0200
      Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-14 09:00 +0200
        Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Tony Lindgren <tony@atomide.com> - 2017-06-14 09:30 +0200

#1664339 — [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

FromHoeun Ryu <hoeun.ryu@gmail.com>
Date2017-06-13 03:20 +0200
Subject[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Message-ID<tRIEV-1n3-9@gated-at.bofh.it>
 omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section
and it's right implementation. But because of this, we cannot enable
CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools
for debugging early boot stage when something goes wrong if you don't have
any hardware based debugging tools like a JTAG debugger.
 This patch is to put the variables into .text section instead only when the
DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only
when ZIMAGE is defined.
 This patch does not change anything when DEBUG_LL_INCLUDE is included in
the other kernel parts like arch/arm/kernel/*

Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
---
 * to mail to relevant recipients, no respond yet from them
   - TO=Tony Lindgren <tony@atomide.com>
   - CC=linux-omap@vger.kernel.org
 * indentical to previous patch

 arch/arm/include/debug/omap2plus.S | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
index 6d867ae..6ce6ef9 100644
--- a/arch/arm/include/debug/omap2plus.S
+++ b/arch/arm/include/debug/omap2plus.S
@@ -58,11 +58,22 @@
 
 #define UART_OFFSET(addr)	((addr) & 0x00ffffff)
 
+/*
+ * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
+ * Place the following block in .text section only when this file is
+ * included by arch/arm/boot/compressed/* to make it possible to
+ * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S
+ * on OMAP2+ SoCs.
+ */
+#ifndef ZIMAGE
 		.pushsection .data
+#endif
 omap_uart_phys:	.word	0
 omap_uart_virt:	.word	0
 omap_uart_lsr:	.word	0
+#ifndef ZIMAGE
 		.popsection
+#endif
 
 		.macro	addruart, rp, rv, tmp
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1664341 — [RESEND PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS

FromHoeun Ryu <hoeun.ryu@gmail.com>
Date2017-06-13 03:20 +0200
Subject[RESEND PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS
Message-ID<tRIEW-1n3-17@gated-at.bofh.it>
In reply to#1664339
 With a patch 9a5151e1d1ba4df41bc4b8e8c0f17163247645ac, "arm:omap2+: put
omap_uart_phys/virt/lsr in .text section when ZIMAGE is true", the
dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS can be dropped,
because all code of omap2+'s DEBUG_LL_INCLUDE file is in .text section when
it's included in the decompressor.

Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
---
 * mail to relevant recipients, no response yet from them.
   - add TO=Tony Lindgren <tony@atomide.com>
   - add CC=linux-omap@vger.kernel.org
 * indentical to previous patch

 arch/arm/Kconfig.debug | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index ba2cb63..52eb0bf 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1735,8 +1735,7 @@ config DEBUG_UART_8250_FLOW_CONTROL
 config DEBUG_UNCOMPRESS
 	bool
 	depends on ARCH_MULTIPLATFORM || PLAT_SAMSUNG || ARM_SINGLE_ARMV7M
-	default y if DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
-		     (!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
+	default y if DEBUG_LL && (!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
 		     !DEBUG_BRCMSTB_UART
 	help
 	  This option influences the normal decompressor output for
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1665430 — Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

FromTony Lindgren <tony@atomide.com>
Date2017-06-14 07:30 +0200
SubjectRe: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Message-ID<tS92q-11P-3@gated-at.bofh.it>
In reply to#1664339
Hi,

* Hoeun Ryu <hoeun.ryu@gmail.com> [170612 18:18]:
> --- a/arch/arm/include/debug/omap2plus.S
> +++ b/arch/arm/include/debug/omap2plus.S
> @@ -58,11 +58,22 @@
>  
>  #define UART_OFFSET(addr)	((addr) & 0x00ffffff)
>  
> +/*
> + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
> + * Place the following block in .text section only when this file is
> + * included by arch/arm/boot/compressed/* to make it possible to
> + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S
> + * on OMAP2+ SoCs.
> + */
> +#ifndef ZIMAGE
>  		.pushsection .data
> +#endif
>  omap_uart_phys:	.word	0
>  omap_uart_virt:	.word	0
>  omap_uart_lsr:	.word	0
> +#ifndef ZIMAGE
>  		.popsection
> +#endif

So I converted all these to use the 8250 debug_ll yesterday
which should solve the DEBUG_UNCOMPRESS issue for you and
allows us to remove this file. Will post the series shortly
for testing with you in Cc after I've done a bit more testing
here.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1665489 — Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

FromHoeun Ryu <hoeun.ryu@gmail.com>
Date2017-06-14 09:00 +0200
SubjectRe: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Message-ID<tSarw-1Mo-13@gated-at.bofh.it>
In reply to#1665430
On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote:
> Hi,
> 
> * Hoeun Ryu <hoeun.ryu@gmail.com> [170612 18:18]:
> > 
> > --- a/arch/arm/include/debug/omap2plus.S
> > +++ b/arch/arm/include/debug/omap2plus.S
> > @@ -58,11 +58,22 @@
> >  
> >  #define UART_OFFSET(addr)	((addr) & 0x00ffffff)
> >  
> > +/*
> > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
> > + * Place the following block in .text section only when this file
> > is
> > + * included by arch/arm/boot/compressed/* to make it possible to
> > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in
> > arch/arm/boot/compressed/head.S
> > + * on OMAP2+ SoCs.
> > + */
> > +#ifndef ZIMAGE
> >  		.pushsection .data
> > +#endif
> >  omap_uart_phys:	.word	0
> >  omap_uart_virt:	.word	0
> >  omap_uart_lsr:	.word	0
> > +#ifndef ZIMAGE
> >  		.popsection
> > +#endif
> So I converted all these to use the 8250 debug_ll yesterday
> which should solve the DEBUG_UNCOMPRESS issue for you and
> allows us to remove this file. Will post the series shortly
> for testing with you in Cc after I've done a bit more testing
> here.

It sounds good.
patch 01 is dropped though, are you using the second patch ?
"[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for
DEBUG_UNCOMPRESS"

Thank you.

> 
> Regards,
> 
> Tony

[toc] | [prev] | [next] | [standalone]

#1665509 — Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

FromTony Lindgren <tony@atomide.com>
Date2017-06-14 09:30 +0200
SubjectRe: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Message-ID<tSaUy-2dU-21@gated-at.bofh.it>
In reply to#1665489
* Hoeun Ryu <hoeun.ryu@gmail.com> [170613 23:57]:
> On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote:
> > So I converted all these to use the 8250 debug_ll yesterday
> > which should solve the DEBUG_UNCOMPRESS issue for you and
> > allows us to remove this file. Will post the series shortly
> > for testing with you in Cc after I've done a bit more testing
> > here.
> 
> It sounds good.
> patch 01 is dropped though, are you using the second patch ?
> "[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for
> DEBUG_UNCOMPRESS"

I folded it into the patch removing all users of DEBUG_OMAP2PLUS_UART
as that seems to make most sense here.

Regards,

Tony

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web