Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664339

[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

From Hoeun Ryu <hoeun.ryu@gmail.com>
Newsgroups linux.kernel
Subject [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Date 2017-06-13 03:20 +0200
Message-ID <tRIEV-1n3-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


 omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section
and it's right implementation. But because of this, we cannot enable
CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools
for debugging early boot stage when something goes wrong if you don't have
any hardware based debugging tools like a JTAG debugger.
 This patch is to put the variables into .text section instead only when the
DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only
when ZIMAGE is defined.
 This patch does not change anything when DEBUG_LL_INCLUDE is included in
the other kernel parts like arch/arm/kernel/*

Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
---
 * to mail to relevant recipients, no respond yet from them
   - TO=Tony Lindgren <tony@atomide.com>
   - CC=linux-omap@vger.kernel.org
 * indentical to previous patch

 arch/arm/include/debug/omap2plus.S | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
index 6d867ae..6ce6ef9 100644
--- a/arch/arm/include/debug/omap2plus.S
+++ b/arch/arm/include/debug/omap2plus.S
@@ -58,11 +58,22 @@
 
 #define UART_OFFSET(addr)	((addr) & 0x00ffffff)
 
+/*
+ * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
+ * Place the following block in .text section only when this file is
+ * included by arch/arm/boot/compressed/* to make it possible to
+ * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S
+ * on OMAP2+ SoCs.
+ */
+#ifndef ZIMAGE
 		.pushsection .data
+#endif
 omap_uart_phys:	.word	0
 omap_uart_virt:	.word	0
 omap_uart_lsr:	.word	0
+#ifndef ZIMAGE
 		.popsection
+#endif
 
 		.macro	addruart, rp, rv, tmp
 
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-13 03:20 +0200
  [RESEND PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-13 03:20 +0200
  Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Tony Lindgren <tony@atomide.com> - 2017-06-14 07:30 +0200
    Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-06-14 09:00 +0200
      Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in  .text section when ZIMAGE is true Tony Lindgren <tony@atomide.com> - 2017-06-14 09:30 +0200

csiph-web