Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664827 > unrolled thread

[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

Back to article view | Back to linux.kernel

Contents

  [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin King <colin.king@canonical.com> - 2017-06-13 15:10 +0200
    Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid  static Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-13 16:20 +0200
    Re: [PATCH][netdev-next] net: hns: make guid  hns_dsaf_acpi_dsm_guid static David Miller <davem@davemloft.net> - 2017-06-13 20:00 +0200
      Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-13 21:30 +0200
        Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid  static Colin Ian King <colin.king@canonical.com> - 2017-06-13 22:50 +0200

#1664827 — [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Colin Ian King <colin.king@canonical.com>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 6b15a507999c..7a8addda726e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -29,7 +29,7 @@ enum _dsm_rst_type {
 	HNS_ROCE_RESET_FUNC     = 0x7,
 };
 
-const guid_t hns_dsaf_acpi_dsm_guid =
+static const guid_t hns_dsaf_acpi_dsm_guid =
 	GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
 		  0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1664917 — Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
> scope, so make it static.
> 
> Cleans up sparse warning:
> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be
> static?"

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> index 6b15a507999c..7a8addda726e 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> @@ -29,7 +29,7 @@ enum _dsm_rst_type {
>  	HNS_ROCE_RESET_FUNC     = 0x7,
>  };
>  
> -const guid_t hns_dsaf_acpi_dsm_guid =
> +static const guid_t hns_dsaf_acpi_dsm_guid =
>  	GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
>  		  0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
>  

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1665077 — Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Colin King <colin.king@canonical.com>
Date: Tue, 13 Jun 2017 14:03:21 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
> scope, so make it static.
> 
> Cleans up sparse warning:
> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

That symbol doesn't even exist in th net-next tree.

[toc] | [prev] | [next] | [standalone]

#1665124

On Tue, Jun 13, 2017 at 8:56 PM, David Miller <davem@davemloft.net> wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Tue, 13 Jun 2017 14:03:21 +0100
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
>> scope, so make it static.
>>
>> Cleans up sparse warning:
>> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> That symbol doesn't even exist in th net-next tree.

It looks like the patch is done against UUID tree.
Cc'ed Christoph.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1665168 — Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

On 13/06/17 20:24, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 8:56 PM, David Miller <davem@davemloft.net> wrote:
>> From: Colin King <colin.king@canonical.com>
>> Date: Tue, 13 Jun 2017 14:03:21 +0100
>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
>>> scope, so make it static.
>>>
>>> Cleans up sparse warning:
>>> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> That symbol doesn't even exist in th net-next tree.
> 
> It looks like the patch is done against UUID tree.
> Cc'ed Christoph.
> 
Sorry, I messed up on determining the original tree it came from in
linux-next when I looked at the output from get_maintainer.pl

Colin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web