Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664917
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static |
| Date | 2017-06-13 16:20 +0200 |
| Message-ID | <tRUPM-zh-7@gated-at.bofh.it> (permalink) |
| References | <tRTK2-8oY-13@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid hns_dsaf_acpi_dsm_guid does not need to be in global
> scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be
> static?"
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> index 6b15a507999c..7a8addda726e 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
> @@ -29,7 +29,7 @@ enum _dsm_rst_type {
> HNS_ROCE_RESET_FUNC = 0x7,
> };
>
> -const guid_t hns_dsaf_acpi_dsm_guid =
> +static const guid_t hns_dsaf_acpi_dsm_guid =
> GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
> 0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin King <colin.king@canonical.com> - 2017-06-13 15:10 +0200
Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-13 16:20 +0200
Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static David Miller <davem@davemloft.net> - 2017-06-13 20:00 +0200
Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-13 21:30 +0200
Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static Colin Ian King <colin.king@canonical.com> - 2017-06-13 22:50 +0200
csiph-web