Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662949 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-06-10 15:00 +0200 |
| Last post | 2017-06-12 23:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-10 15:00 +0200
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface "Andrew F. Davis" <afd@ti.com> - 2017-06-12 16:30 +0200
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-12 16:30 +0200
[PATCH] DocBook: w1: Update W1 file locations and names in DocBook "Andrew F. Davis" <afd@ti.com> - 2017-06-12 16:50 +0200
Re: [PATCH] DocBook: w1: Update W1 file locations and names in DocBook kbuild test robot <lkp@intel.com> - 2017-06-12 23:30 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-10 15:00 +0200 |
| Subject | Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface |
| Message-ID | <tQO9I-78u-5@gated-at.bofh.it> |
On Mon, Jun 05, 2017 at 08:52:08AM -0500, Andrew F. Davis wrote:
> Like other subsystems we should be able to define slave devices outside
> of the w1 directory. To do this we move public facing interface
> definitions to include/linux/w1.h and rename the internal definition
> file to w1_internal.h.
>
> As w1_family.h and w1_int.h contained almost entirely public
> driver interface definitions we simply removed these files and
> moved the remaining definitions into w1_internal.h.
>
> With this we can now start to move slave devices out of w1/slaves and
> into the subsystem based on the function they implement, again like
> other drivers.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Sebastian Reichel <sre@kernel.org>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> MAINTAINERS | 1 +
> drivers/power/supply/ds2760_battery.c | 2 +-
> drivers/power/supply/ds2780_battery.c | 2 +-
> drivers/power/supply/ds2781_battery.c | 2 +-
> drivers/w1/masters/ds1wm.c | 3 +-
> drivers/w1/masters/ds2482.c | 3 +-
> drivers/w1/masters/ds2490.c | 3 +-
> drivers/w1/masters/matrox_w1.c | 3 +-
> drivers/w1/masters/mxc_w1.c | 3 +-
> drivers/w1/masters/omap_hdq.c | 3 +-
> drivers/w1/masters/w1-gpio.c | 3 +-
> drivers/w1/slaves/w1_bq27000.c | 6 +-
> drivers/w1/slaves/w1_ds2405.c | 5 +-
> drivers/w1/slaves/w1_ds2406.c | 6 +-
> drivers/w1/slaves/w1_ds2408.c | 6 +-
> drivers/w1/slaves/w1_ds2413.c | 6 +-
> drivers/w1/slaves/w1_ds2423.c | 6 +-
> drivers/w1/slaves/w1_ds2431.c | 6 +-
> drivers/w1/slaves/w1_ds2433.c | 6 +-
> drivers/w1/slaves/w1_ds2438.c | 5 +-
> drivers/w1/slaves/w1_ds2760.c | 7 ++-
> drivers/w1/slaves/w1_ds2780.c | 7 ++-
> drivers/w1/slaves/w1_ds2781.c | 7 ++-
> drivers/w1/slaves/w1_ds28e04.c | 6 +-
> drivers/w1/slaves/w1_smem.c | 7 ++-
> drivers/w1/slaves/w1_therm.c | 10 ++-
> drivers/w1/w1.c | 6 +-
> drivers/w1/w1_family.c | 3 +-
> drivers/w1/w1_family.h | 98 -----------------------------
> drivers/w1/w1_int.c | 3 +-
> drivers/w1/w1_int.h | 27 --------
> drivers/w1/w1_internal.h | 87 ++++++++++++++++++++++++++
> drivers/w1/w1_io.c | 2 +-
> drivers/w1/w1_netlink.c | 2 +-
> drivers/w1/w1_netlink.h | 2 +-
> {drivers/w1 => include/linux}/w1.h | 114 +++++++++++++++-------------------
> 36 files changed, 208 insertions(+), 260 deletions(-)
> delete mode 100644 drivers/w1/w1_family.h
> delete mode 100644 drivers/w1/w1_int.h
> create mode 100644 drivers/w1/w1_internal.h
> rename {drivers/w1 => include/linux}/w1.h (76%)
You forgot to update Documentation/DocBook/w1.tmpl, and now the
documentation build breaks :(
Can you please send me a patch to fix that up?
thanks,
greg k-h
[toc] | [next] | [standalone]
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2017-06-12 16:30 +0200 |
| Message-ID | <tRyvU-3dT-15@gated-at.bofh.it> |
| In reply to | #1662949 |
On 06/10/2017 07:51 AM, Greg Kroah-Hartman wrote:
> On Mon, Jun 05, 2017 at 08:52:08AM -0500, Andrew F. Davis wrote:
>> Like other subsystems we should be able to define slave devices outside
>> of the w1 directory. To do this we move public facing interface
>> definitions to include/linux/w1.h and rename the internal definition
>> file to w1_internal.h.
>>
>> As w1_family.h and w1_int.h contained almost entirely public
>> driver interface definitions we simply removed these files and
>> moved the remaining definitions into w1_internal.h.
>>
>> With this we can now start to move slave devices out of w1/slaves and
>> into the subsystem based on the function they implement, again like
>> other drivers.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> Reviewed-by: Sebastian Reichel <sre@kernel.org>
>> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>> ---
>> MAINTAINERS | 1 +
>> drivers/power/supply/ds2760_battery.c | 2 +-
>> drivers/power/supply/ds2780_battery.c | 2 +-
>> drivers/power/supply/ds2781_battery.c | 2 +-
>> drivers/w1/masters/ds1wm.c | 3 +-
>> drivers/w1/masters/ds2482.c | 3 +-
>> drivers/w1/masters/ds2490.c | 3 +-
>> drivers/w1/masters/matrox_w1.c | 3 +-
>> drivers/w1/masters/mxc_w1.c | 3 +-
>> drivers/w1/masters/omap_hdq.c | 3 +-
>> drivers/w1/masters/w1-gpio.c | 3 +-
>> drivers/w1/slaves/w1_bq27000.c | 6 +-
>> drivers/w1/slaves/w1_ds2405.c | 5 +-
>> drivers/w1/slaves/w1_ds2406.c | 6 +-
>> drivers/w1/slaves/w1_ds2408.c | 6 +-
>> drivers/w1/slaves/w1_ds2413.c | 6 +-
>> drivers/w1/slaves/w1_ds2423.c | 6 +-
>> drivers/w1/slaves/w1_ds2431.c | 6 +-
>> drivers/w1/slaves/w1_ds2433.c | 6 +-
>> drivers/w1/slaves/w1_ds2438.c | 5 +-
>> drivers/w1/slaves/w1_ds2760.c | 7 ++-
>> drivers/w1/slaves/w1_ds2780.c | 7 ++-
>> drivers/w1/slaves/w1_ds2781.c | 7 ++-
>> drivers/w1/slaves/w1_ds28e04.c | 6 +-
>> drivers/w1/slaves/w1_smem.c | 7 ++-
>> drivers/w1/slaves/w1_therm.c | 10 ++-
>> drivers/w1/w1.c | 6 +-
>> drivers/w1/w1_family.c | 3 +-
>> drivers/w1/w1_family.h | 98 -----------------------------
>> drivers/w1/w1_int.c | 3 +-
>> drivers/w1/w1_int.h | 27 --------
>> drivers/w1/w1_internal.h | 87 ++++++++++++++++++++++++++
>> drivers/w1/w1_io.c | 2 +-
>> drivers/w1/w1_netlink.c | 2 +-
>> drivers/w1/w1_netlink.h | 2 +-
>> {drivers/w1 => include/linux}/w1.h | 114 +++++++++++++++-------------------
>> 36 files changed, 208 insertions(+), 260 deletions(-)
>> delete mode 100644 drivers/w1/w1_family.h
>> delete mode 100644 drivers/w1/w1_int.h
>> create mode 100644 drivers/w1/w1_internal.h
>> rename {drivers/w1 => include/linux}/w1.h (76%)
>
> You forgot to update Documentation/DocBook/w1.tmpl, and now the
> documentation build breaks :(
>
> Can you please send me a patch to fix that up?
It looks like in -next DocBook/w1.tmpl has been converted to
driver-api/w1.rst, should I just fix up the .rst version, or would you
also like a patch for your tree to keep it building for now?
Thanks,
Andrew
>
> thanks,
>
> greg k-h
>
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-12 16:30 +0200 |
| Message-ID | <tRyvV-3dT-37@gated-at.bofh.it> |
| In reply to | #1663545 |
On Mon, Jun 12, 2017 at 09:24:04AM -0500, Andrew F. Davis wrote:
> On 06/10/2017 07:51 AM, Greg Kroah-Hartman wrote:
> > On Mon, Jun 05, 2017 at 08:52:08AM -0500, Andrew F. Davis wrote:
> >> Like other subsystems we should be able to define slave devices outside
> >> of the w1 directory. To do this we move public facing interface
> >> definitions to include/linux/w1.h and rename the internal definition
> >> file to w1_internal.h.
> >>
> >> As w1_family.h and w1_int.h contained almost entirely public
> >> driver interface definitions we simply removed these files and
> >> moved the remaining definitions into w1_internal.h.
> >>
> >> With this we can now start to move slave devices out of w1/slaves and
> >> into the subsystem based on the function they implement, again like
> >> other drivers.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> Reviewed-by: Sebastian Reichel <sre@kernel.org>
> >> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> >> ---
> >> MAINTAINERS | 1 +
> >> drivers/power/supply/ds2760_battery.c | 2 +-
> >> drivers/power/supply/ds2780_battery.c | 2 +-
> >> drivers/power/supply/ds2781_battery.c | 2 +-
> >> drivers/w1/masters/ds1wm.c | 3 +-
> >> drivers/w1/masters/ds2482.c | 3 +-
> >> drivers/w1/masters/ds2490.c | 3 +-
> >> drivers/w1/masters/matrox_w1.c | 3 +-
> >> drivers/w1/masters/mxc_w1.c | 3 +-
> >> drivers/w1/masters/omap_hdq.c | 3 +-
> >> drivers/w1/masters/w1-gpio.c | 3 +-
> >> drivers/w1/slaves/w1_bq27000.c | 6 +-
> >> drivers/w1/slaves/w1_ds2405.c | 5 +-
> >> drivers/w1/slaves/w1_ds2406.c | 6 +-
> >> drivers/w1/slaves/w1_ds2408.c | 6 +-
> >> drivers/w1/slaves/w1_ds2413.c | 6 +-
> >> drivers/w1/slaves/w1_ds2423.c | 6 +-
> >> drivers/w1/slaves/w1_ds2431.c | 6 +-
> >> drivers/w1/slaves/w1_ds2433.c | 6 +-
> >> drivers/w1/slaves/w1_ds2438.c | 5 +-
> >> drivers/w1/slaves/w1_ds2760.c | 7 ++-
> >> drivers/w1/slaves/w1_ds2780.c | 7 ++-
> >> drivers/w1/slaves/w1_ds2781.c | 7 ++-
> >> drivers/w1/slaves/w1_ds28e04.c | 6 +-
> >> drivers/w1/slaves/w1_smem.c | 7 ++-
> >> drivers/w1/slaves/w1_therm.c | 10 ++-
> >> drivers/w1/w1.c | 6 +-
> >> drivers/w1/w1_family.c | 3 +-
> >> drivers/w1/w1_family.h | 98 -----------------------------
> >> drivers/w1/w1_int.c | 3 +-
> >> drivers/w1/w1_int.h | 27 --------
> >> drivers/w1/w1_internal.h | 87 ++++++++++++++++++++++++++
> >> drivers/w1/w1_io.c | 2 +-
> >> drivers/w1/w1_netlink.c | 2 +-
> >> drivers/w1/w1_netlink.h | 2 +-
> >> {drivers/w1 => include/linux}/w1.h | 114 +++++++++++++++-------------------
> >> 36 files changed, 208 insertions(+), 260 deletions(-)
> >> delete mode 100644 drivers/w1/w1_family.h
> >> delete mode 100644 drivers/w1/w1_int.h
> >> create mode 100644 drivers/w1/w1_internal.h
> >> rename {drivers/w1 => include/linux}/w1.h (76%)
> >
> > You forgot to update Documentation/DocBook/w1.tmpl, and now the
> > documentation build breaks :(
> >
> > Can you please send me a patch to fix that up?
>
> It looks like in -next DocBook/w1.tmpl has been converted to
> driver-api/w1.rst, should I just fix up the .rst version, or would you
> also like a patch for your tree to keep it building for now?
Fixing up my tree would be best for now.
We can handle the merge issue if it happens afterward.
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2017-06-12 16:50 +0200 |
| Subject | [PATCH] DocBook: w1: Update W1 file locations and names in DocBook |
| Message-ID | <tRyPf-3kj-3@gated-at.bofh.it> |
| In reply to | #1663554 |
Some of the files in the W1 subsystem have been moved or renamed,
update the documentation for the same.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
Documentation/DocBook/w1.tmpl | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/DocBook/w1.tmpl b/Documentation/DocBook/w1.tmpl
index b0228d4c81bb..c65cb27abef9 100644
--- a/Documentation/DocBook/w1.tmpl
+++ b/Documentation/DocBook/w1.tmpl
@@ -51,9 +51,9 @@
<sect1 id="w1_internal_api">
<title>W1 API internal to the kernel</title>
<sect2 id="w1.h">
- <title>drivers/w1/w1.h</title>
- <para>W1 core functions.</para>
-!Idrivers/w1/w1.h
+ <title>include/linux/w1.h</title>
+ <para>W1 kernel API functions.</para>
+!Iinclude/linux/w1.h
</sect2>
<sect2 id="w1.c">
@@ -62,18 +62,18 @@
!Idrivers/w1/w1.c
</sect2>
- <sect2 id="w1_family.h">
- <title>drivers/w1/w1_family.h</title>
- <para>Allows registering device family operations.</para>
-!Idrivers/w1/w1_family.h
- </sect2>
-
<sect2 id="w1_family.c">
<title>drivers/w1/w1_family.c</title>
<para>Allows registering device family operations.</para>
!Edrivers/w1/w1_family.c
</sect2>
+ <sect2 id="w1_internal.h">
+ <title>drivers/w1/w1_internal.h</title>
+ <para>W1 internal initialization for master devices.</para>
+!Idrivers/w1/w1_internal.h
+ </sect2>
+
<sect2 id="w1_int.c">
<title>drivers/w1/w1_int.c</title>
<para>W1 internal initialization for master devices.</para>
--
2.13.0
[toc] | [prev] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2017-06-12 23:30 +0200 |
| Subject | Re: [PATCH] DocBook: w1: Update W1 file locations and names in DocBook |
| Message-ID | <tRF4m-7wC-17@gated-at.bofh.it> |
| In reply to | #1663580 |
[Multipart message — attachments visible in raw view] — view raw
Hi Andrew, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc5] [cannot apply to next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andrew-F-Davis/DocBook-w1-Update-W1-file-locations-and-names-in-DocBook/20170613-035424 reproduce: make htmldocs All errors (new ones prefixed by >>): >> docproc: include/linux/w1.h: No such file or directory --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web