Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663545
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface |
| Date | 2017-06-12 16:30 +0200 |
| Message-ID | <tRyvU-3dT-15@gated-at.bofh.it> (permalink) |
| References | <tP0I2-3zX-3@gated-at.bofh.it> <tP0I2-3zX-5@gated-at.bofh.it> <tQO9I-78u-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/10/2017 07:51 AM, Greg Kroah-Hartman wrote:
> On Mon, Jun 05, 2017 at 08:52:08AM -0500, Andrew F. Davis wrote:
>> Like other subsystems we should be able to define slave devices outside
>> of the w1 directory. To do this we move public facing interface
>> definitions to include/linux/w1.h and rename the internal definition
>> file to w1_internal.h.
>>
>> As w1_family.h and w1_int.h contained almost entirely public
>> driver interface definitions we simply removed these files and
>> moved the remaining definitions into w1_internal.h.
>>
>> With this we can now start to move slave devices out of w1/slaves and
>> into the subsystem based on the function they implement, again like
>> other drivers.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> Reviewed-by: Sebastian Reichel <sre@kernel.org>
>> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>> ---
>> MAINTAINERS | 1 +
>> drivers/power/supply/ds2760_battery.c | 2 +-
>> drivers/power/supply/ds2780_battery.c | 2 +-
>> drivers/power/supply/ds2781_battery.c | 2 +-
>> drivers/w1/masters/ds1wm.c | 3 +-
>> drivers/w1/masters/ds2482.c | 3 +-
>> drivers/w1/masters/ds2490.c | 3 +-
>> drivers/w1/masters/matrox_w1.c | 3 +-
>> drivers/w1/masters/mxc_w1.c | 3 +-
>> drivers/w1/masters/omap_hdq.c | 3 +-
>> drivers/w1/masters/w1-gpio.c | 3 +-
>> drivers/w1/slaves/w1_bq27000.c | 6 +-
>> drivers/w1/slaves/w1_ds2405.c | 5 +-
>> drivers/w1/slaves/w1_ds2406.c | 6 +-
>> drivers/w1/slaves/w1_ds2408.c | 6 +-
>> drivers/w1/slaves/w1_ds2413.c | 6 +-
>> drivers/w1/slaves/w1_ds2423.c | 6 +-
>> drivers/w1/slaves/w1_ds2431.c | 6 +-
>> drivers/w1/slaves/w1_ds2433.c | 6 +-
>> drivers/w1/slaves/w1_ds2438.c | 5 +-
>> drivers/w1/slaves/w1_ds2760.c | 7 ++-
>> drivers/w1/slaves/w1_ds2780.c | 7 ++-
>> drivers/w1/slaves/w1_ds2781.c | 7 ++-
>> drivers/w1/slaves/w1_ds28e04.c | 6 +-
>> drivers/w1/slaves/w1_smem.c | 7 ++-
>> drivers/w1/slaves/w1_therm.c | 10 ++-
>> drivers/w1/w1.c | 6 +-
>> drivers/w1/w1_family.c | 3 +-
>> drivers/w1/w1_family.h | 98 -----------------------------
>> drivers/w1/w1_int.c | 3 +-
>> drivers/w1/w1_int.h | 27 --------
>> drivers/w1/w1_internal.h | 87 ++++++++++++++++++++++++++
>> drivers/w1/w1_io.c | 2 +-
>> drivers/w1/w1_netlink.c | 2 +-
>> drivers/w1/w1_netlink.h | 2 +-
>> {drivers/w1 => include/linux}/w1.h | 114 +++++++++++++++-------------------
>> 36 files changed, 208 insertions(+), 260 deletions(-)
>> delete mode 100644 drivers/w1/w1_family.h
>> delete mode 100644 drivers/w1/w1_int.h
>> create mode 100644 drivers/w1/w1_internal.h
>> rename {drivers/w1 => include/linux}/w1.h (76%)
>
> You forgot to update Documentation/DocBook/w1.tmpl, and now the
> documentation build breaks :(
>
> Can you please send me a patch to fix that up?
It looks like in -next DocBook/w1.tmpl has been converted to
driver-api/w1.rst, should I just fix up the .rst version, or would you
also like a patch for your tree to keep it building for now?
Thanks,
Andrew
>
> thanks,
>
> greg k-h
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-10 15:00 +0200
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface "Andrew F. Davis" <afd@ti.com> - 2017-06-12 16:30 +0200
Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-12 16:30 +0200
[PATCH] DocBook: w1: Update W1 file locations and names in DocBook "Andrew F. Davis" <afd@ti.com> - 2017-06-12 16:50 +0200
Re: [PATCH] DocBook: w1: Update W1 file locations and names in DocBook kbuild test robot <lkp@intel.com> - 2017-06-12 23:30 +0200
csiph-web