Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662814 > unrolled thread
| Started by | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| First post | 2017-06-10 01:20 +0200 |
| Last post | 2017-06-13 16:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-06-10 01:20 +0200
Re: [PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 16:10 +0200
| From | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| Date | 2017-06-10 01:20 +0200 |
| Subject | [PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context |
| Message-ID | <tQBm9-7M4-13@gated-at.bofh.it> |
get_free_pipe_id_locked() is called with spinlock held, so the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid sleeping in atomic spinlock context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index 2de1e603bd2b..5f3672153b12 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -704,7 +704,7 @@ static int get_free_pipe_id_locked(struct goldfish_pipe_dev *dev) /* Reallocate the array */ u32 new_capacity = 2 * dev->pipes_capacity; struct goldfish_pipe **pipes = - kcalloc(new_capacity, sizeof(*pipes), GFP_KERNEL); + kcalloc(new_capacity, sizeof(*pipes), GFP_ATOMIC); if (!pipes) return -ENOMEM; memcpy(pipes, dev->pipes, sizeof(*pipes) * dev->pipes_capacity); -- 2.7.4
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-13 16:10 +0200 |
| Subject | Re: [PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context |
| Message-ID | <tRUG5-w3-5@gated-at.bofh.it> |
| In reply to | #1662814 |
On Sat, Jun 10, 2017 at 02:18:26AM +0300, Alexey Khoroshilov wrote: > get_free_pipe_id_locked() is called with spinlock held, so > the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid > sleeping in atomic spinlock context. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > --- > drivers/platform/goldfish/goldfish_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is already in my tree, why resend it? thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web