[PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context

From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	[PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context
Date	2017-06-10 01:20 +0200
Message-ID	<tQBm9-7M4-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

get_free_pipe_id_locked() is called with spinlock held, so
the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid
sleeping in atomic spinlock context.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/platform/goldfish/goldfish_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 2de1e603bd2b..5f3672153b12 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -704,7 +704,7 @@ static int get_free_pipe_id_locked(struct goldfish_pipe_dev *dev)
 		/* Reallocate the array */
 		u32 new_capacity = 2 * dev->pipes_capacity;
 		struct goldfish_pipe **pipes =
-			kcalloc(new_capacity, sizeof(*pipes), GFP_KERNEL);
+			kcalloc(new_capacity, sizeof(*pipes), GFP_ATOMIC);
 		if (!pipes)
 			return -ENOMEM;
 		memcpy(pipes, dev->pipes, sizeof(*pipes) * dev->pipes_capacity);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-06-10 01:20 +0200
  Re: [PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in  spinlock context Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 16:10 +0200

csiph-web