Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664842 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-13 15:20 +0200 |
| Last post | 2017-06-19 12:30 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King <colin.king@canonical.com> - 2017-06-13 15:20 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Adrian Hunter <adrian.hunter@intel.com> - 2017-06-14 08:20 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-19 12:30 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Christoph Hellwig <hch@lst.de> - 2017-06-19 12:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-13 15:20 +0200 |
| Subject | [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static |
| Message-ID | <tRTTI-8sf-21@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The guid intel_dsm_guid does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'intel_dsm_guid' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/host/sdhci-pci-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 3c02c5b394d6..f1d8385d91f0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -404,7 +404,7 @@ struct intel_host {
bool d3_retune;
};
-const guid_t intel_dsm_guid =
+static const guid_t intel_dsm_guid =
GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
--
2.11.0
[toc] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-06-14 08:20 +0200 |
| Message-ID | <tS9ON-1zn-3@gated-at.bofh.it> |
| In reply to | #1664842 |
On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
But this patch is dependent on the guid changes which are not in the mmc
tree. It's in a tree of Christoph's I think.
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
>
[toc] | [prev] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-06-19 12:30 +0200 |
| Message-ID | <tU26u-1nN-27@gated-at.bofh.it> |
| In reply to | #1665471 |
On 14 June 2017 at 08:08, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 13/06/17 16:14, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The guid intel_dsm_guid does not need to be in global scope, so make
>> it static.
>>
>> Cleans up sparse warning:
>> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> But this patch is dependent on the guid changes which are not in the mmc
> tree. It's in a tree of Christoph's I think.
Right, in such case maybe Christoph can pick this up?
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
>> ---
>> drivers/mmc/host/sdhci-pci-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index 3c02c5b394d6..f1d8385d91f0 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -404,7 +404,7 @@ struct intel_host {
>> bool d3_retune;
>> };
>>
>> -const guid_t intel_dsm_guid =
>> +static const guid_t intel_dsm_guid =
>> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-06-19 12:30 +0200 |
| Subject | Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static |
| Message-ID | <tU26u-1nN-39@gated-at.bofh.it> |
| In reply to | #1668982 |
Please resend any patches I should pick up directly to me, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web