Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665471
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static |
| Date | 2017-06-14 08:20 +0200 |
| Message-ID | <tS9ON-1zn-3@gated-at.bofh.it> (permalink) |
| References | <tRTTI-8sf-21@gated-at.bofh.it> |
| Organization | Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki |
On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
But this patch is dependent on the guid changes which are not in the mmc
tree. It's in a tree of Christoph's I think.
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King <colin.king@canonical.com> - 2017-06-13 15:20 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Adrian Hunter <adrian.hunter@intel.com> - 2017-06-14 08:20 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-19 12:30 +0200
Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Christoph Hellwig <hch@lst.de> - 2017-06-19 12:30 +0200
csiph-web