Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664652 > unrolled thread

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 11:50 +0200
    Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold <johan@kernel.org> - 2017-06-13 12:00 +0200
      Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold <johan@kernel.org> - 2017-06-13 12:10 +0200
      Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 12:10 +0200

#1664652 — Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> On Tue,  6 Jun 2017 12:54:40 +0200
> Johan Hovold <johan@kernel.org> wrote:
> 
> > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > severe bit rot.
> 
> I would be amazed if the IRDA code still works. It's not been tested
> properly for years and it never followed the tty rules properly in the
> first place - so this looks good, although moving IRDA into staging
> and /dev/null would IMHO be far better.
> 
> IRDA is dead, and IR remotes are handled via completely different code.

I agree, and we should move it into staging and out of the tree, I'll
send netdev some patches for that...

thanks,

greg k-h

[toc] | [next] | [standalone]

#1664657

On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> > On Tue,  6 Jun 2017 12:54:40 +0200
> > Johan Hovold <johan@kernel.org> wrote:
> > 
> > > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > > severe bit rot.
> > 
> > I would be amazed if the IRDA code still works. It's not been tested
> > properly for years and it never followed the tty rules properly in the
> > first place - so this looks good, although moving IRDA into staging
> > and /dev/null would IMHO be far better.
> > 
> > IRDA is dead, and IR remotes are handled via completely different code.
> 
> I agree, and we should move it into staging and out of the tree, I'll
> send netdev some patches for that...

Sounds good, but please consider applying this patch before moving to
staging as people have been modifying this dead code as part of
kernel-wide updates even though hasn't even compiled for quite some
time.

Thanks,
Johan

[toc] | [prev] | [next] | [standalone]

#1664675

On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote:
> On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> > > On Tue,  6 Jun 2017 12:54:40 +0200
> > > Johan Hovold <johan@kernel.org> wrote:
> > > 
> > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > > > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > > > severe bit rot.
> > > 
> > > I would be amazed if the IRDA code still works. It's not been tested
> > > properly for years and it never followed the tty rules properly in the
> > > first place - so this looks good, although moving IRDA into staging
> > > and /dev/null would IMHO be far better.
> > > 
> > > IRDA is dead, and IR remotes are handled via completely different code.
> > 
> > I agree, and we should move it into staging and out of the tree, I'll
> > send netdev some patches for that...
> 
> Sounds good, but please consider applying this patch before moving to
> staging as people have been modifying this dead code as part of
> kernel-wide updates even though hasn't even compiled for quite some
> time.

That is, just that which you ended up doing. :)

Thanks,
Johan

[toc] | [prev] | [next] | [standalone]

#1664686

On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote:
> On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> > > On Tue,  6 Jun 2017 12:54:40 +0200
> > > Johan Hovold <johan@kernel.org> wrote:
> > > 
> > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > > > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > > > severe bit rot.
> > > 
> > > I would be amazed if the IRDA code still works. It's not been tested
> > > properly for years and it never followed the tty rules properly in the
> > > first place - so this looks good, although moving IRDA into staging
> > > and /dev/null would IMHO be far better.
> > > 
> > > IRDA is dead, and IR remotes are handled via completely different code.
> > 
> > I agree, and we should move it into staging and out of the tree, I'll
> > send netdev some patches for that...
> 
> Sounds good, but please consider applying this patch before moving to
> staging as people have been modifying this dead code as part of
> kernel-wide updates even though hasn't even compiled for quite some
> time.

I already applied it :)

I'll wait for 4.13-rc1 before doing it (if I remember...)

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web