Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code
Date	2017-06-13 12:00 +0200
Message-ID	<tRQM9-6li-1@gated-at.bofh.it> (permalink)
References	<tPknn-7Bq-5@gated-at.bofh.it> <tPknq-7Bq-57@gated-at.bofh.it> <tPkQp-89v-11@gated-at.bofh.it> <tRQCu-6hR-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote:
> > On Tue,  6 Jun 2017 12:54:40 +0200
> > Johan Hovold <johan@kernel.org> wrote:
> > 
> > > Remove three ifdefed and broken implementations of TIOCSSERIAL and
> > > TIOCGICOUNT, and parity handling in set_termios which had suffered
> > > severe bit rot.
> > 
> > I would be amazed if the IRDA code still works. It's not been tested
> > properly for years and it never followed the tty rules properly in the
> > first place - so this looks good, although moving IRDA into staging
> > and /dev/null would IMHO be far better.
> > 
> > IRDA is dead, and IR remotes are handled via completely different code.
> 
> I agree, and we should move it into staging and out of the tree, I'll
> send netdev some patches for that...

Sounds good, but please consider applying this patch before moving to
staging as people have been modifying this dead code as part of
kernel-wide updates even though hasn't even compiled for quite some
time.

Thanks,
Johan

Thread

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 11:50 +0200
  Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold <johan@kernel.org> - 2017-06-13 12:00 +0200
    Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold <johan@kernel.org> - 2017-06-13 12:10 +0200
    Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-13 12:10 +0200

csiph-web