Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663134 > unrolled thread

[PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

Back to article view | Back to linux.kernel

Contents

  [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga <jayad@cdac.in> - 2017-06-11 20:50 +0200
    Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-12 14:20 +0200
      Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 08:00 +0200
        Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue R Jayadurga <jayad@cdac.in> - 2017-06-13 09:00 +0200
    Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue Guenter Roeck <linux@roeck-us.net> - 2017-06-12 23:00 +0200

#1663134 — [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

Fixed WARNING: line over 80 characters

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/rtl8712/ieee80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index 6e673c1..97ef063 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
	sz += 8;
	ie += sz;
	/*beacon interval : 2bytes*/
-	*(__le16 *)ie = cpu_to_le16(
-				(u16)pdev_network->configuration.beacon_period);
+	struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
+	*(__le16 *)ie = cpu_to_le16(cfg->beacon_period);
	sz += 2;
	ie += 2;
	/*capability info*/
--
1.9.1

[toc] | [next] | [standalone]

#1663459 — Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

The patch numbering doesn't make sense.

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1664455 — Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> This e-mail is for the sole use of the intended recipient(s) and may
> contain confidential and privileged information. If you are not the
> intended recipient, please contact the sender by reply e-mail and destroy
> all copies and the original message. Any unauthorized review, use,
> disclosure, dissemination, forwarding, printing or copying of this email
> is strictly prohibited and appropriate legal action will be taken.
> -------------------------------------------------------------------------------------------------------------------------------

As per your footer, I am deleting your email.

Please note that I'm really not supposed to be responding to this at
all, as this type of text is not allowed at all on kernel development
mialing lists...

[toc] | [prev] | [next] | [standalone]

#1664507 — Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue

sorry for the inconvenience caused i have corrected it.

Regards,
Jaya Durga R

On June 13, 2017 at 11:25 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> > This e-mail is for the sole use of the intended recipient(s) and may
> > contain confidential and privileged information. If you are not the
> > intended recipient, please contact the sender by reply e-mail and destroy
> > all copies and the original message. Any unauthorized review, use,
> > disclosure, dissemination, forwarding, printing or copying of this email
> > is strictly prohibited and appropriate legal action will be taken.
> > -------------------------------------------------------------------------------------------------------------------------------
>
> As per your footer, I am deleting your email.
>
> Please note that I'm really not supposed to be responding to this at
> all, as this type of text is not allowed at all on kernel development
> mialing lists...

-------------------------------------------------------------------------------------------------------------------------------
[ C-DAC is on Social-Media too. Kindly follow us at:
Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------

[toc] | [prev] | [next] | [standalone]

#1664219 — Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue

On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
> 
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
>  drivers/staging/rtl8712/ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 1.9.1
> 
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 6e673c1..97ef063 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
> 	sz += 8;
> 	ie += sz;
> 	/*beacon interval : 2bytes*/
> -	*(__le16 *)ie = cpu_to_le16(
> -				(u16)pdev_network->configuration.beacon_period);
> +	struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
> +	*(__le16 *)ie = cpu_to_le16(cfg->beacon_period);

Do you really think that the resulting 

drivers/staging/rtl8712/ieee80211.c:177:2: warning:
	ISO C90 forbids mixed declarations and code

is better ?

Guenter

> 	sz += 2;
> 	ie += 2;
> 	/*capability info*/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web