Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue
Date	2017-06-12 23:00 +0200
Message-ID	<tREBk-77B-11@gated-at.bofh.it> (permalink)
References	<tRg5X-8vh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
> 
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
>  drivers/staging/rtl8712/ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 1.9.1
> 
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 6e673c1..97ef063 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
> 	sz += 8;
> 	ie += sz;
> 	/*beacon interval : 2bytes*/
> -	*(__le16 *)ie = cpu_to_le16(
> -				(u16)pdev_network->configuration.beacon_period);
> +	struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
> +	*(__le16 *)ie = cpu_to_le16(cfg->beacon_period);

Do you really think that the resulting 

drivers/staging/rtl8712/ieee80211.c:177:2: warning:
	ISO C90 forbids mixed declarations and code

is better ?

Guenter

> 	sz += 2;
> 	ie += 2;
> 	/*capability info*/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga <jayad@cdac.in> - 2017-06-11 20:50 +0200
  Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-12 14:20 +0200
    Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 08:00 +0200
      Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style  issue R Jayadurga <jayad@cdac.in> - 2017-06-13 09:00 +0200
  Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue Guenter Roeck <linux@roeck-us.net> - 2017-06-12 23:00 +0200

csiph-web