Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662013 > unrolled thread

Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent  PCI device Linus Walleij <linus.walleij@linaro.org> - 2017-06-09 09:30 +0200
    Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent  PCI device Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-09 09:50 +0200

#1662013 — Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device

On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

> This fixes reloading of the GPIO driver for the same platform device
> instance as created by the exar UART driver: First of all, the driver
> sets drvdata to its own value during probing and does not restore the
> original value on exit. But this won't help anyway as the core clears
> drvdata after the driver left.
>
> Set the platform device parent instead.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

If I get Gregs ACK on this I can merge patches 2-11 through the
GPIO tree.

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1662040

On 2017-06-09 09:21, Linus Walleij wrote:
> On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> This fixes reloading of the GPIO driver for the same platform device
>> instance as created by the exar UART driver: First of all, the driver
>> sets drvdata to its own value during probing and does not restore the
>> original value on exit. But this won't help anyway as the core clears
>> drvdata after the driver left.
>>
>> Set the platform device parent instead.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> If I get Gregs ACK on this I can merge patches 2-11 through the
> GPIO tree.
> 

Patch 10 needs an update, Andy had remarks. I need to resync and send it
- there will be v6 soon.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web