Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662013

Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device
Date 2017-06-09 09:30 +0200
Message-ID <tQmwN-72q-5@gated-at.bofh.it> (permalink)
References <tNPbZ-6hW-27@gated-at.bofh.it> <tNPlF-6o8-45@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

> This fixes reloading of the GPIO driver for the same platform device
> instance as created by the exar UART driver: First of all, the driver
> sets drvdata to its own value during probing and does not restore the
> original value on exit. But this won't help anyway as the core clears
> drvdata after the driver left.
>
> Set the platform device parent instead.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

If I get Gregs ACK on this I can merge patches 2-11 through the
GPIO tree.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent  PCI device Linus Walleij <linus.walleij@linaro.org> - 2017-06-09 09:30 +0200
  Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent  PCI device Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-09 09:50 +0200

csiph-web