Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660198 > unrolled thread

[PATCH] IB/qib: remove duplicate code

Started by"Gustavo A. R. Silva" <garsilva@embeddedor.com>
First post2017-06-07 22:50 +0200
Last post2017-06-08 22:00 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] IB/qib: remove duplicate code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-07 22:50 +0200
    Re: [PATCH] IB/qib: remove duplicate code Leon Romanovsky <leon@kernel.org> - 2017-06-08 12:40 +0200
    Re: [PATCH] IB/qib: remove duplicate code Dennis Dalessandro <dennis.dalessandro@intel.com> - 2017-06-08 15:20 +0200
      Re: [PATCH] IB/qib: remove duplicate code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-08 22:00 +0200

#1660198 — [PATCH] IB/qib: remove duplicate code

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-07 22:50 +0200
Subject[PATCH] IB/qib: remove duplicate code
Message-ID<tPQ3U-34T-25@gated-at.bofh.it>
Remove duplicate code.

Addresses-Coverity-ID: 1226951
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/infiniband/hw/qib/qib_mad.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index da295e0..c5eaa3c 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
 		ib_dispatch_event(&event);
 	}
 
-	ret = subn_get_portinfo(smp, ibdev, port);
-
 	/* restore re-reg bit per o14-12.2.1 */
 	pip->clientrereg_resv_subnetto |= clientrereg;
 
-- 
2.5.0

[toc] | [next] | [standalone]

#1661046

FromLeon Romanovsky <leon@kernel.org>
Date2017-06-08 12:40 +0200
Message-ID<tQ318-36s-21@gated-at.bofh.it>
In reply to#1660198

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jun 07, 2017 at 03:42:02PM -0500, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>  1 file changed, 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[toc] | [prev] | [next] | [standalone]

#1661164

FromDennis Dalessandro <dennis.dalessandro@intel.com>
Date2017-06-08 15:20 +0200
Message-ID<tQ5vY-4Kf-11@gated-at.bofh.it>
In reply to#1660198
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
> 
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>   drivers/infiniband/hw/qib/qib_mad.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index da295e0..c5eaa3c 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
>   		ib_dispatch_event(&event);
>   	}
>   
> -	ret = subn_get_portinfo(smp, ibdev, port);
> -
>   	/* restore re-reg bit per o14-12.2.1 */
>   	pip->clientrereg_resv_subnetto |= clientrereg;
>   
> 

Would be nice to see a few more words in the commit message rather than 
having to go look for Coverity.

Regardless, patch seems fine to me code wise.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

[toc] | [prev] | [next] | [standalone]

#1661631

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-08 22:00 +0200
Message-ID<tQbL4-4U-7@gated-at.bofh.it>
In reply to#1661164
Hi Dennis,

Quoting Dennis Dalessandro <dennis.dalessandro@intel.com>:

> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c  
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp  
>> *smp, struct ib_device *ibdev,
>>  		ib_dispatch_event(&event);
>>  	}
>>  -	ret = subn_get_portinfo(smp, ibdev, port);
>> -
>>  	/* restore re-reg bit per o14-12.2.1 */
>>  	pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather  
> than having to go look for Coverity.
>

I'll take note of that.

> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Thank you
--
Gustavo A. R. Silva

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web