Re: [PATCH] IB/qib: remove duplicate code

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/qib: remove duplicate code
Date	2017-06-08 22:00 +0200
Message-ID	<tQbL4-4U-7@gated-at.bofh.it> (permalink)
References	<tPQ3U-34T-25@gated-at.bofh.it> <tQ5vY-4Kf-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Dennis,

Quoting Dennis Dalessandro <dennis.dalessandro@intel.com>:

> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c  
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp  
>> *smp, struct ib_device *ibdev,
>>  		ib_dispatch_event(&event);
>>  	}
>>  -	ret = subn_get_portinfo(smp, ibdev, port);
>> -
>>  	/* restore re-reg bit per o14-12.2.1 */
>>  	pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather  
> than having to go look for Coverity.
>

I'll take note of that.

> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Thank you
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/qib: remove duplicate code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-07 22:50 +0200
  Re: [PATCH] IB/qib: remove duplicate code Leon Romanovsky <leon@kernel.org> - 2017-06-08 12:40 +0200
  Re: [PATCH] IB/qib: remove duplicate code Dennis Dalessandro <dennis.dalessandro@intel.com> - 2017-06-08 15:20 +0200
    Re: [PATCH] IB/qib: remove duplicate code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-08 22:00 +0200

csiph-web