Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661581 > unrolled thread

Re: [PATCH v2] um: add dummy ioremap and iounmap functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-06-08 21:00 +0200
    Re: [PATCH v2] um: add dummy ioremap and iounmap functions Richard Weinberger <richard@nod.at> - 2017-06-08 21:20 +0200

#1661581 — Re: [PATCH v2] um: add dummy ioremap and iounmap functions

Any thoughts on this? My patches for the other architectures are already
in linux-next. um is the only one that remains.

Thanks,

Logan

On 27/05/17 12:15 PM, Logan Gunthorpe wrote:
> Hi,
> 
> On 27/05/17 12:08 PM, Geert Uytterhoeven wrote:
>> Still, those code patch could be protected by #ifdef CONFIG_HAS_IOMEM,
>> or better, if (IS_ENABLED(CONFIG_HAS_IOMEM)).
> 
> Well I think it would have to be the former seeing the latter would
> still end up trying to compile the missing function. But having ifdefs
> inside code is not generally seen as good idea[1].
> 
> I'd really like to go forward with either this patch or something like
> it. The other two arches that have this problem are fine with merging a
> fix and adding ifdefs to work around a single arch doesn't feel right to me.
> 
> Thanks,
> 
> Logan
> 
> [1] http://yarchive.net/comp/linux/ifdefs.html
> 

[toc] | [next] | [standalone]

#1661604

Am 08.06.2017 um 20:53 schrieb Logan Gunthorpe:
> Any thoughts on this? My patches for the other architectures are already
> in linux-next. um is the only one that remains.

IMHO an ifdef in scatterlist code does not hurt.
It is equally ugly than mocking ioremap for UML.

So, I'm puzzled.
Arnd, what do you think?
Shall !HAS_IOMEM archs just mock these functions?

Thanks,
//richard

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web